Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10 [v3]

2022-07-26 Thread Alisen Chung
> open l10n msg drop > All tests passed. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: removed localized files from base - Changes: - all: https://git.openjdk.org/jdk19/pull/154/files - new: https://git.openjdk.org

Integrated: JDK-8290887 Unused private method in TrustManagerFactoryImpl

2022-07-26 Thread Mark Powers
On Fri, 22 Jul 2022 17:59:51 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8290887 This pull request has now been integrated. Changeset: 4d796ee8 Author:Mark Powers Committer: Sean Mullan URL: https://git.openjdk.org/jdk/commit/4d796ee8abd4eabc5d5d3034f236e8f4289ca0

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10 [v2]

2022-07-26 Thread Alisen Chung
> open l10n msg drop > All tests passed. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: merged currencyname property files into localedata - Changes: - all: https://git.openjdk.org/jdk19/pull/154/files - new: https:

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

2022-07-26 Thread Alisen Chung
On Mon, 25 Jul 2022 18:48:25 GMT, Alexey Semenyuk wrote: > Why `MSG_Help_mac_launcher` in > [src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_de.properties](https://github.com/openjdk/jdk19/pull/154/files#diff-2e1b121e201e1040827d5b68ebdd852615e611904db783806a753dc698

Re: RFR: JDK-8290887 Unused private method in TrustManagerFactoryImpl [v2]

2022-07-26 Thread Sean Mullan
On Tue, 26 Jul 2022 15:07:03 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8290887 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > second iteration Marked as reviewed by mullan (Reviewer). - P

Re: RFR: JDK-8290887 Unused private method in TrustManagerFactoryImpl [v2]

2022-07-26 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8290887 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: second iteration - Changes: - all: https://git.openjdk.org/jdk/pull/9616/files - new: https://git.openjdk.org/jdk/pull/9616

Integrated: 8290669: Fix wording in sun.security.ec

2022-07-26 Thread longxu0509
On Fri, 22 Jul 2022 02:15:44 GMT, longxu0509 wrote: > this patch fixes several wording in sun.security.ec This pull request has now been integrated. Changeset: 2ae8e311 Author:longxu0509 Committer: John Jiang URL: https://git.openjdk.org/jdk/commit/2ae8e3118385bdf93c50bca550334734b

Re: RFR: 8290669: Fix wording in sun.security.ec

2022-07-26 Thread John Jiang
On Fri, 22 Jul 2022 02:15:44 GMT, longxu0509 wrote: > this patch fixes several wording in sun.security.ec Just changed the label in this JBS. Thanks! - PR: https://git.openjdk.org/jdk/pull/9606

Re: RFR: 8290669: Fix wording in sun.security.ec

2022-07-26 Thread Sean Mullan
On Fri, 22 Jul 2022 02:15:44 GMT, longxu0509 wrote: > this patch fixes several wording in sun.security.ec I think "noreg-trivial" is a more appropriate label for this bug than "noreg-cleanup". "noreg-cleanup", as defined in the [OpenJDK Developer's Guide](https://openjdk.org/guide/) is: "Chan

Re: RFR: 8290669: Fix wording in sun.security.ec

2022-07-26 Thread Sean Mullan
On Fri, 22 Jul 2022 02:15:44 GMT, longxu0509 wrote: > this patch fixes several wording in sun.security.ec Marked as reviewed by mullan (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9606

Re: RFR: JDK-8290887 Unused private method in TrustManagerFactoryImpl

2022-07-26 Thread Sean Mullan
On Fri, 22 Jul 2022 17:59:51 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8290887 src/java.base/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java line 108: > 106: } > 107: > 108: /* I think you can also remove the `import java.io.*` on line 28 now that this