Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes

2022-07-19 Thread Matthias Baesken
On Tue, 19 Jul 2022 20:37:09 GMT, Valerie Peng wrote: > None of the 3 proposed error codes in this PR is in the standard PKCS#11 > header files - two of them are vendor specific. For vendor specific error > code, such direct mapping may be incorrect. As for CKR_COPY_PROHIBITED, I > can't find

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-07-19 Thread David Holmes
On Mon, 18 Jul 2022 23:27:58 GMT, David Holmes wrote: >> src/java.base/share/man/keytool.1 line 456: >> >>> 454: \f[CB]PrivateKeyEntry\f[R] for the signer that already exists in the >>> 455: keystore. >>> 456: This option is used to sign the certificate with the signer?s private >> >> Not a pro

[jdk19] Integrated: 8278274: Update nroff pages in JDK 19 before RC

2022-07-19 Thread David Holmes
On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote: > Please review these changes to the nroff manpage files so that they match > their markdown sources that Oracle maintains. > > All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022 > if needed. Additionally: > > T

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki [v4]

2022-07-19 Thread Valerie Peng
On Thu, 14 Jul 2022 02:48:07 GMT, Julian Waters wrote: >> Several instances of function pointers in jdk.crypto.cryptoki are marked >> with the dllimport attribute, which should only be applied to symbol >> declarations, of which a typedef'd function pointer is not. This would only >> be useful

Re: RFR: 8288568: Reduce runtime of java.security microbenchmarks [v2]

2022-07-19 Thread David Schlosnagle
On Fri, 17 Jun 2022 12:24:50 GMT, Claes Redestad wrote: >> - Reduce forks, iteration, runtime to reduce runtime while maintaining high >> data quality on typical benchmarking hosts. >> >> Reduces runtime from estimated 10+ hours to 54 minutes. > > Claes Redestad has updated the pull request inc

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes

2022-07-19 Thread Valerie Peng
On Tue, 19 Jul 2022 13:14:17 GMT, Matthias Baesken wrote: > The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the > following PKCS11 exception (see attached jtr files of that bug) : > > Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 > > Unfortuna

Re: RFR: JDK-8155039 Simplify code to setup SSLContextImpl and TrustManagerFactoryImpl

2022-07-19 Thread Weijun Wang
On Mon, 18 Jul 2022 17:53:56 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8155039 We can do them in a separate cleanup and close this one with Will-Not-Fix. Otherwise, you need to change the title of this bug to "cleanup something" and a historian will find it confusing on wha

Re: RFR: JDK-8155039 Simplify code to setup SSLContextImpl and TrustManagerFactoryImpl

2022-07-19 Thread Mark Powers
On Mon, 18 Jul 2022 17:53:56 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8155039 Can't say I disagree. That would leave removing the unused method from TrustManagerFactoryImpl.java and a couple of typos. - PR: https://git.openjdk.org/jdk/pull/9542

Re: RFR: JDK-8155039 Simplify code to setup SSLContextImpl and TrustManagerFactoryImpl

2022-07-19 Thread Weijun Wang
On Mon, 18 Jul 2022 17:53:56 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8155039 I'm not sure if this is worth doing. It looks like after the code change each of the 2 constructors is only used once by one of the 2 new `privilegedGetFileInputStream` methods, and then each new

RFR: JDK-8155039 Simplify code to setup SSLContextImpl and TrustManagerFactoryImpl

2022-07-19 Thread Mark Powers
https://bugs.openjdk.org/browse/JDK-8155039 - Commit messages: - fourth iteration - third iteration - second iteration - first iteration Changes: https://git.openjdk.org/jdk/pull/9542/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9542&range=00 Issue: https://bugs.open

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes

2022-07-19 Thread Matthias Baesken
On Tue, 19 Jul 2022 13:14:17 GMT, Matthias Baesken wrote: > The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the > following PKCS11 exception (see attached jtr files of that bug) : > > Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 > > Unfortuna

RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes

2022-07-19 Thread Matthias Baesken
The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the following PKCS11 exception (see attached jtr files of that bug) : Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 Unfortunately the error code 0xCE534351 is currently not in the RV/errorMap tabl