Re: RFR: 8289572: InputStream wrapping with BufferedInputStream is redundant in HttpTimestamper

2022-07-14 Thread Сергей Цыпанов
On Thu, 14 Jul 2022 17:51:43 GMT, Sean Mullan wrote: >> In case we read all bytes from an `InputStream` we don't need wrapping with >> `BufferedInputStream` as the bytes are not written into internal buffer. >> With removal of redundant buffer we save 8 kB of allocated memory. > > This is in se

Re: RFR: 8289572: InputStream wrapping with BufferedInputStream is redundant in HttpTimestamper

2022-07-14 Thread Sean Mullan
On Fri, 1 Jul 2022 08:06:10 GMT, Сергей Цыпанов wrote: > In case we read all bytes from an `InputStream` we don't need wrapping with > `BufferedInputStream` as the bytes are not written into internal buffer. With > removal of redundant buffer we save 8 kB of allocated memory. Marked as reviewe

Re: RFR: 8289572: InputStream wrapping with BufferedInputStream is redundant in HttpTimestamper

2022-07-14 Thread Sean Mullan
On Fri, 1 Jul 2022 08:06:10 GMT, Сергей Цыпанов wrote: > In case we read all bytes from an `InputStream` we don't need wrapping with > `BufferedInputStream` as the bytes are not written into internal buffer. With > removal of redundant buffer we save 8 kB of allocated memory. This is in securi

RE: Case-sensitive Keystore for PKCS#12

2022-07-14 Thread Ravi Patel8
Thank you for the suggested solutions with an added attribute and a new provider. Do you think it is something that could be contributed to the JDK, or do you suggest this should be taken up as an external provider? From: security-dev on behalf of Xuelei Fan Se

Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[] [v5]

2022-07-14 Thread Andrey Turbanov
On Wed, 13 Jul 2022 17:42:18 GMT, Сергей Цыпанов wrote: >> We can skip bounds check and null check for Charset in case we use the array >> entirely and the Charset is either default one or proven to be non-null. >> >> Benchmark results: >> >> before >> >> Benchmark