Re: RFR: 8170762: Document that ISO10126Padding pads with random bytes

2022-07-05 Thread Kevin Driver
On Fri, 1 Jul 2022 23:38:51 GMT, Bradford Wetmore wrote: >> JDK-8170762 - update Javadoc to indicate ISO10126Padding pads with random >> bytes, though the spec does not require random bytes > > Just a comment, I believe both approaches are ok. The ISO 10126 spec says: > >> When padding with oc

Re: RFR: JDK-8284851 Update javax.crypto files to use proper javadoc for mentioned classes [v6]

2022-07-05 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8284851 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: aw shucks - another one - Changes: - all: https://git.openjdk.org/jdk/pull/9282/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: JDK-8284851 Update javax.crypto files to use proper javadoc for mentioned classes [v5]

2022-07-05 Thread Mark Powers
On Fri, 1 Jul 2022 23:59:02 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8284851 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Max comments continued Found and fixed a `{@code }` missing the `}`. --

Re: RFR: JDK-8284851 Update javax.crypto files to use proper javadoc for mentioned classes [v6]

2022-07-05 Thread Mark Powers
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8284851 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > aw shucks - another one The pre-submit that fails doesn't appear to have any

Re: RFR: JDK-8284851 Update javax.crypto files to use proper javadoc for mentioned classes [v2]

2022-07-05 Thread Mark Powers
On Tue, 28 Jun 2022 20:44:04 GMT, Weijun Wang wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Valerie fix > > src/java.base/share/classes/java/security/KeyStoreException.java line 44: > >> 42: /** >> 43: *