On Tue, 28 Jun 2022 13:20:53 GMT, zzambers wrote:
>> SunPkcs11 provider throws out of bounds exception during encryption when
>> specific conditions are met.
>>
>> Exception:
>>
>> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
>> index out of range: 32
>> at
On Tue, 28 Jun 2022 13:20:53 GMT, zzambers wrote:
>> SunPkcs11 provider throws out of bounds exception during encryption when
>> specific conditions are met.
>>
>> Exception:
>>
>> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
>> index out of range: 32
>> at
> https://bugs.openjdk.org/browse/JDK-8284851
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
Max comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9282/files
- new: https://git.openjdk.org/jdk/pull/9282/fil
On Tue, 28 Jun 2022 19:59:24 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/java/security/AccessController.java line 983:
>
>> 981:
>> 982: /**
>>
On Tue, 28 Jun 2022 13:20:53 GMT, zzambers wrote:
>> SunPkcs11 provider throws out of bounds exception during encryption when
>> specific conditions are met.
>>
>> Exception:
>>
>> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
>> index out of range: 32
>> at
On Thu, 30 Jun 2022 18:39:48 GMT, Xue-Lei Andrew Fan wrote:
>> test/lib/jdk/test/lib/util/ForceGC.java line 58:
>>
>>> 56: Reference.reachabilityFence(ref);
>>> 57:
>>> 58: for (int retries = (int)(timeout / 200); retries >= 0;
>>> retries--) {
>>
>> The logic around the timeo
On Thu, 30 Jun 2022 18:44:30 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
>> open part looks good to me. Please help to run Mach5 just case the closed
>> test cases are
On Thu, 30 Jun 2022 18:24:14 GMT, Xue-Lei Andrew Fan wrote:
>> test/lib/jdk/test/lib/util/ForceGC.java line 70:
>>
>>> 68: // But it is fine. For most cases, the 1st GC is
>>> sufficient
>>> 69: // to trigger and complete the cleanup.
>>> 70: que
On Thu, 30 Jun 2022 15:48:07 GMT, Roger Riggs wrote:
>> Xue-Lei Andrew Fan has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Master
>> - use Reference.refersTo
>> - remove trailing whitespaces
>> - use timeou
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the pull request increme
On Thu, 30 Jun 2022 15:53:10 GMT, Roger Riggs wrote:
>> Xue-Lei Andrew Fan has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Master
>> - use Reference.refersTo
>> - remove trailing whitespaces
>> - use timeou
> https://bugs.openjdk.org/browse/JDK-8284851
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
Valerie fix continued
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9282/files
- new: https://git.openjdk.org/jdk/pull
On Wed, 29 Jun 2022 01:01:44 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/javax/crypto/ProviderVerifier.java line 170:
>>
>>> 168: * NOTE: if this ProviderVerifier instance is
>>> constructed
>>> 169: * with "savePerms" equal to false, then this method would always
>>>
On Tue, 28 Jun 2022 22:06:00 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/javax/crypto/KeyGenerator.java line 297:
>>
>>> 295: *
>>> 296: * A new {@code KeyGenerator} object encapsulating the
>>> 297: * {@code KeyGeneratorSpi} implementation from the specified
>>> Pro
On Wed, 29 Jun 2022 21:29:41 GMT, Valerie Peng wrote:
>> In this case the sentence was about initializing a cipher object, so I
>> changed it to `{@code Cipher}`. If a sentence says "cipher block size" then
>> I tried to leave it alone because it's referring to an algorithm rather than
>> a cl
On Wed, 29 Jun 2022 21:31:31 GMT, Valerie Peng wrote:
>> Are you suggesting that whenever file is modified, **all** occurrences of
>> `` should be changed to `{@code }`?
>
> At least for new changes, I prefer to use new notations.. If its easier to
> replace all, that's fine with me too.
Chang
On Tue, 28 Jun 2022 20:17:23 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/javax/crypto/AEADBadTagException.java line 48:
>
>> 46:
>> 47: /**
>>
On Tue, 28 Jun 2022 20:47:56 GMT, Mark Powers wrote:
>> src/java.base/share/classes/javax/crypto/AEADBadTagException.java line 41:
>>
>>> 39:
>>> 40: /**
>>> 41: * Constructs an AEADBadTagException with no detail
>>> message.
>>
>> Why not using the {@code } as in other files?
>
> I
On Sat, 18 Jun 2022 05:55:32 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
>> open part looks good to me. Please help to run Mach5 just case the closed
>> test cases are
On Sat, 18 Jun 2022 05:55:32 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
>> open part looks good to me. Please help to run Mach5 just case the closed
>> test cases are
20 matches
Mail list logo
