On Tue, 28 Jun 2022 21:50:17 GMT, Mark Powers wrote:
>> src/java.base/share/classes/javax/crypto/CryptoPolicyParser.java line 47:
>>
>>> 45: * that JCE has new permission classes called
>>> 46: * javax.crypto.CryptoPermission and
>>> 47: * javax.crypto.CryptoAllPermission.
>>
>> Use` {@code
On Tue, 28 Jun 2022 21:09:56 GMT, Mark Powers wrote:
>> Personally, I'd against making this change, i.e. changing all "cipher"
>> occurrences to "{@code Cipher}". Can we just stick to fixing what's broken?
>
> In this case the sentence was about initializing a cipher object, so I
> changed it t
On Tue, 7 Jun 2022 22:07:17 GMT, zzambers wrote:
> TLS `*_CHACHA20_POLY1305_*` cipher suites are currently broken when
> configuration with SunPKCS11 provider is used. I discovered this by my
> ssl-tests testsuite [1].
>
>
> make TEST_PKCS11_FIPS=1
> SSLTESTS_SSL_CONFIG_FILTER=SunJSSE,Defaul
On Wed, 29 Jun 2022 13:44:11 GMT, Weijun Wang wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> src/java.base/share/classes/sun/security/x509/X509CertImpl.java line 742:
>
>> 7
> Could you please review the changes?
> This is to address the issue:
> https://bugs.openjdk.org/browse/JDK-8283082?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comments. A
On Wed, 29 Jun 2022 13:44:11 GMT, Weijun Wang wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> src/java.base/share/classes/sun/security/x509/X509CertImpl.java line 742:
>
>> 7
On Wed, 29 Jun 2022 13:41:33 GMT, Weijun Wang wrote:
>>> The test can be much simpler than the program included in the bug report.
>>> Something like this:
>>>
>>> 1. Create an empty `X509CertImpl`
>>>
>>> 2. Add "x509.info"
>>>
>>> 3. Add "x509.info.issuer"
>>>
>>> 4. Remove
On Wed, 29 Jun 2022 02:46:48 GMT, Jayashree Huttanagoudar
wrote:
>> Thank you for taking a look at the PR.
>> Sure I will address these comments.
>
>> The test can be much simpler than the program included in the bug report.
>> Something like this:
>>
>> 1. Create an empty `X509CertImpl`
>
On Wed, 29 Jun 2022 02:39:26 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This is to address the issue:
>> https://bugs.openjdk.org/browse/JDK-8283082?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
