On Tue, 28 Jun 2022 14:49:52 GMT, Jayashree Huttanagoudar
wrote:
>> The test can be much simpler than the program included in the bug report.
>> Something like this:
>>
>> 1. Create an empty `X509CertImpl`
>> 2. Add "x509.info"
>> 3. Add "x509.info.issuer"
>> 4. Remove "x509.info.issuer"
>> 5.
> Could you please review the changes?
> This is to address the issue:
> https://bugs.openjdk.org/browse/JDK-8283082?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comments
-
On Tue, 28 Jun 2022 22:13:25 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/javax/crypto/ProviderVerifier.java line 170:
>
>> 168: * NOTE: if this
On Thu, 23 Jun 2022 23:01:36 GMT, Valerie Peng wrote:
>> I have addressed both remarks.
>> jdk_security tests passed for me locally with this change.
>> Thanks
>
>> I have addressed both remarks. jdk_security tests passed for me locally with
>> this change. Thanks
>
> I will submit a test job o
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/SecretKeyFactory.java
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/KeyGenerator.java line
On Tue, 28 Jun 2022 22:02:31 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/javax/crypto/KeyGenerator.java line 297:
>
>> 295: *
>> 296: * A
On Tue, 28 Jun 2022 22:55:26 GMT, Hai-May Chao wrote:
> Test TestRawRSACipher.java may fail intermittently. Please review changes to
> dump out the input and output when it fails.
This pull request has now been integrated.
Changeset: 7b3bf977
Author:Hai-May Chao
URL:
https://git.op
On Tue, 28 Jun 2022 23:18:28 GMT, Weijun Wang wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update to use HexFormat
>
> Looks fine.
@wangweij Thanks for the review.
-
PR: https://git.openjdk.org/jd
On Tue, 28 Jun 2022 23:22:20 GMT, Hai-May Chao wrote:
>> Test TestRawRSACipher.java may fail intermittently. Please review changes to
>> dump out the input and output when it fails.
>
> Hai-May Chao has updated the pull request incrementally with one additional
> commit since the last revision:
> Test TestRawRSACipher.java may fail intermittently. Please review changes to
> dump out the input and output when it fails.
Hai-May Chao has updated the pull request incrementally with one additional
commit since the last revision:
Update to use HexFormat
-
Changes:
- all: h
Test TestRawRSACipher.java may fail intermittently. Please review changes to
dump out the input and output when it fails.
-
Commit messages:
- 8289401: Add dump output to TestRawRSACipher.java
Changes: https://git.openjdk.org/jdk/pull/9316/files
Webrev: https://webrevs.openjdk.org
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/KeyGenerator.java line
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/ExemptionMechanism.jav
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInf
On Tue, 28 Jun 2022 21:32:47 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/javax/crypto/CryptoPolicyParser.java line 47:
>
>> 45: * that JCE has new
On Tue, 28 Jun 2022 13:20:53 GMT, zzambers wrote:
>> SunPkcs11 provider throws out of bounds exception during encryption when
>> specific conditions are met.
>>
>> Exception:
>>
>> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
>> index out of range: 32
>> at
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/CryptoPolicyParser.jav
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/CryptoPermission.java
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/CipherOutputStream.jav
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
This is the `java.security` part.
src/java.base/share/classes/
On Tue, 28 Jun 2022 20:33:17 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/javax/crypto/Cipher.java line 184:
>>
>>> 182:
>>> 183: /**
>>> 184: * Constant used to initialize {@code Cipher} to encryption mode.
>>
>> If it's lower case, we normally just leave it? Not sure what
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/CipherOutputStream.jav
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/CipherOutputStream.jav
On Tue, 28 Jun 2022 20:16:37 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/javax/crypto/AEADBadTagException.java line 41:
>
>> 39:
>> 40: /**
>>
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/CipherInputStream.java
On Tue, 28 Jun 2022 20:21:34 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/javax/crypto/Cipher.java line 184:
>
>> 182:
>> 183: /**
>> 184:
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/AEADBadTagException.ja
On Tue, 28 Jun 2022 19:31:54 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/java/security/AccessControlContext.java line 58:
>
>> 56: * of the current
> https://bugs.openjdk.org/browse/JDK-8284851
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
Valerie fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9282/files
- new: https://git.openjdk.org/jdk/pull/9282/file
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/java/security/AccessControlContext.
On Thu, 23 Jun 2022 23:01:36 GMT, Valerie Peng wrote:
>> I have addressed both remarks.
>> jdk_security tests passed for me locally with this change.
>> Thanks
>
>> I have addressed both remarks. jdk_security tests passed for me locally with
>> this change. Thanks
>
> I will submit a test job o
On Mon, 27 Jun 2022 13:18:44 GMT, zzambers wrote:
>> TLS `*_CHACHA20_POLY1305_*` cipher suites are currently broken when
>> configuration with SunPKCS11 provider is used. I discovered this by my
>> ssl-tests testsuite [1].
>>
>>
>> make TEST_PKCS11_FIPS=1
>> SSLTESTS_SSL_CONFIG_FILTER=SunJSS
> TLS `*_CHACHA20_POLY1305_*` cipher suites are currently broken when
> configuration with SunPKCS11 provider is used. I discovered this by my
> ssl-tests testsuite [1].
>
>
> make TEST_PKCS11_FIPS=1
> SSLTESTS_SSL_CONFIG_FILTER=SunJSSE,Default,TLSv1.2,TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256
On Tue, 28 Jun 2022 13:26:47 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/x509/X509CertImpl.java line 742:
>>
>>> 740:
>>> 741: if (id.equalsIgnoreCase(INFO)) {
>>> 742: if (!(attr.getSuffix() != null)) {
>>
>> You can simply update the `!=` to `==`.
On Fri, 24 Jun 2022 16:48:46 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8284851
Missing '-': changed "JDK 8284851" to JDK-8284851.
From: TheShermanTanker ***@***.***>
Sent: Tuesday, June 28, 2022 4:12 AM
To: openjdk/jdk ***@***.***>
Cc: Mark Po
On Fri, 24 Jun 2022 16:48:46 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8284851
@mcpowers Seems like Skara didn't correctly detect and link the JBS entry. Try
renaming your title to just "8284851" and see if that works (It may take a
while)
-
PR: https://git.op
https://bugs.openjdk.org/browse/JDK-8284851
-
Commit messages:
- mo polish
- polish
- Merge
- second round
- Merge
- first round
Changes: https://git.openjdk.org/jdk/pull/9282/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9282&range=00
Issue: https://bugs.openjdk.or
On Tue, 28 Jun 2022 13:17:42 GMT, Weijun Wang wrote:
>> Could you please review the changes?
>> This is to address the issue:
>> https://bugs.openjdk.org/browse/JDK-8283082?jql=labels%20%3D%20starter-bug
>
> src/java.base/share/classes/sun/security/x509/X509CertImpl.java line 742:
>
>> 740:
>>
On Tue, 28 Jun 2022 08:33:58 GMT, Jayashree Huttanagoudar
wrote:
> Could you please review the changes?
> This is to address the issue:
> https://bugs.openjdk.org/browse/JDK-8283082?jql=labels%20%3D%20starter-bug
src/java.base/share/classes/sun/security/x509/X509CertImpl.java line 742:
> 740:
On Tue, 28 Jun 2022 12:57:21 GMT, zzambers wrote:
> SunPkcs11 provider throws out of bounds exception during encryption when
> specific conditions are met.
>
> Exception:
>
> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
> index out of range: 32
> at java.ba
> SunPkcs11 provider throws out of bounds exception during encryption when
> specific conditions are met.
>
> Exception:
>
> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
> index out of range: 32
> at java.base/java.util.Arrays.rangeCheck(Arrays.java:725)
>
SunPkcs11 provider throws out of bounds exception during encryption when
specific conditions are met.
Exception:
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
index out of range: 32
at java.base/java.util.Arrays.rangeCheck(Arrays.java:725)
at java.ba
Could you please review the changes?
This is to address the issue:
https://bugs.openjdk.org/browse/JDK-8283082?jql=labels%20%3D%20starter-bug
-
Commit messages:
- 8283082: sun.security.x509.X509CertImpl.delete("x509.info.validity") nulls
out info field
Changes: https://git.openjdk
Several instances of function pointers in jdk.crypto.cryptoki are marked with
the dllimport attribute, which should only be applied to symbol declarations,
of which a typedef'd function pointer is not. In addition to being incorrect,
at least on the versions of Visual C++ the JDK supports today,
Update code checks both non-null and instance of a class in security classes.
The checks and explicit casts could also be replaced with pattern matching for
the instanceof operator.
See similar cleanup in java.base -
[JDK-8258422](https://bugs.openjdk.java.net/browse/JDK-8258422)
-
46 matches
Mail list logo
