Re: RFR: 8287596: Reorg jdk.test.lib.util.ForceGC [v9]

2022-06-17 Thread Xue-Lei Andrew Fan
On Thu, 16 Jun 2022 16:08:04 GMT, Roger Riggs wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove trailing whitespaces > > test/jdk/java/io/ObjectStreamClass/TestOSCClassLoaderLeak.java line 64: > >> 62:

Re: RFR: 8287596: Reorg jdk.test.lib.util.ForceGC [v10]

2022-06-17 Thread Xue-Lei Andrew Fan
> This is a follow up update per comments in [JDK-8287384 > PR](https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/8907__;!!ACWV5N9M2RV99hQ!NNGX7uEj58t7UHOcS2PbUgT_R8PW8A2xNlmJ5N8WuCcgG8EPOLJBHAjRiwhXq_NhJ33K0VrDlHQxNLJpVy9XSw$ > ). The tier1 and tier2 test in open part looks good t

Re: RFR: 8286395: Address possibly lossy conversions in java.security.jgss

2022-06-17 Thread kristylee88
On Fri, 17 Jun 2022 16:09:41 GMT, Ryan Ernst wrote: > Applied required casts in java.security.jgss for the upcoming warning. > Verified by cherry-picking @asotona's patch. Marked as reviewed by kristyle...@github.com (no known OpenJDK username). - PR: https://git.openjdk.org/jdk/pu

Re: RFR: 8288568: Reduce runtime of java.security microbenchmarks [v2]

2022-06-17 Thread Hai-May Chao
On Fri, 17 Jun 2022 12:24:50 GMT, Claes Redestad wrote: >> - Reduce forks, iteration, runtime to reduce runtime while maintaining high >> data quality on typical benchmarking hosts. >> >> Reduces runtime from estimated 10+ hours to 54 minutes. > > Claes Redestad has updated the pull request inc

Re: RFR: 8287809: Revisit implementation of memory session [v4]

2022-06-17 Thread Maurizio Cimadamore
On Fri, 17 Jun 2022 20:39:40 GMT, Maurizio Cimadamore wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert implicit vs. heap session changes > > src/java.base/share/classes/jdk/internal/foreign/AbstractMe

Re: RFR: 8287809: Revisit implementation of memory session [v4]

2022-06-17 Thread Maurizio Cimadamore
On Fri, 17 Jun 2022 18:39:03 GMT, Maurizio Cimadamore wrote: >> This is a JDK 19 clone of: >> https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9017__;!!ACWV5N9M2RV99hQ!Off-l8NwzAhR8cTQMgW01NR8g_uIjxXm-ftxHRQTWaGPkYDn4G75Nu_mGQ7UaX1HyCOQcQqZA0SL02LVyrHqkt4deq2b$ >> > > Maurizio

Re: RFR: 8287809: Revisit implementation of memory session [v4]

2022-06-17 Thread Maurizio Cimadamore
> This is a JDK 19 clone of: > https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9017__;!!ACWV5N9M2RV99hQ!PDiDD7tpqoYwjNISzsD57v-URWsuxLBHjmp7XC7fR0hzuYt2MRflM8_6NU2jfsXK3HxUNhXRZQtpOHvwmbzoJYtLC1v2$ > Maurizio Cimadamore has updated the pull request incrementally with one additi

Re: RFR: 8287809: Revisit implementation of memory session [v2]

2022-06-17 Thread Maurizio Cimadamore
On Fri, 17 Jun 2022 18:19:22 GMT, Maurizio Cimadamore wrote: >> This is a JDK 19 clone of: >> https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9017__;!!ACWV5N9M2RV99hQ!MJBIdOCiCKapELuC4Frw5pEuyVqRHww-MJCCcp8fMDAaZcb6YI6rfye8wDUuXhq1hH1KW5uKFYelFb2-TUmhiC3KLuku$ >> > > Maurizio

Re: RFR: 8287809: Revisit implementation of memory session [v3]

2022-06-17 Thread Maurizio Cimadamore
> This is a JDK 19 clone of: > https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9017__;!!ACWV5N9M2RV99hQ!LasBnmlQqj3d1rqmNV1QR8r1A712unwkWeIA-hKEZUsYJKufBEFTSX-saLL9b-ktzJmys5eM5ztcf8vK9D7eX3399d8g$ > Maurizio Cimadamore has updated the pull request incrementally with one additi

Re: RFR: 8287809: Revisit implementation of memory session [v2]

2022-06-17 Thread Maurizio Cimadamore
> This is a JDK 19 clone of: > https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9017__;!!ACWV5N9M2RV99hQ!LqHfEzMnB5I2tQcPYGNk5lbO6mqR2JyzHIqL69ssF926nQucUWim_jTb-W8SGJKAO5suXHZeN0knE-kE0kLuHY9chG57$ > Maurizio Cimadamore has updated the pull request with a new target base due to

Re: RFR: 8286389: Address possibly lossy conversions in jdk.crypto.ec

2022-06-17 Thread Chris Hegarty
On Fri, 17 Jun 2022 16:05:38 GMT, Ryan Ernst wrote: > Applied required casts in jdk.crypto.ec for the upcoming warning. > Verified by cherry-picking @asotona's patch. Looks good to me. I'm happy to sponsor this change, once a reviewer from the security area has had a chance to take a look. ---

Re: RFR: 8286395: Address possibly lossy conversions in java.security.jgss

2022-06-17 Thread Chris Hegarty
On Fri, 17 Jun 2022 16:09:41 GMT, Ryan Ernst wrote: > Applied required casts in java.security.jgss for the upcoming warning. > Verified by cherry-picking @asotona's patch. Looks good to me. I'm happy to sponsor this change, once a reviewer from the security area has had a chance to take a look.

Re: Wrong mailadresses in List-mail-headers in mails from security-dev@

2022-06-17 Thread Sean Mullan
This should be fixed now. Let us know if you see any more problems. --Sean On 6/16/22 5:22 PM, Sean Mullan wrote: Thanks, looking into the issue and will get back to you. --Sean On 6/16/22 4:09 PM, Lothar Kimmeringer wrote: Hi, I've had the pronblem that mails, I've sent to the list, got lo

RFR: 8286395: Address possibly lossy conversions in java.security.jgss

2022-06-17 Thread Ryan Ernst
Applied required casts in java.security.jgss for the upcoming warning. Verified by cherry-picking @asotona's patch. - Commit messages: - 8286395: Address possibly lossy conversions in java.security.jgss Changes: https://git.openjdk.org/jdk/pull/9204/files Webrev: https://webrevs.op

RFR: 8286389: Address possibly lossy conversions in jdk.crypto.ec

2022-06-17 Thread Ryan Ernst
Applied required casts in jdk.crypto.ec for the upcoming warning. Verified by cherry-picking @asotona's patch. - Commit messages: - 8286389: Address possibly lossy conversions in jdk.crypto.ec Changes: https://git.openjdk.org/jdk/pull/9203/files Webrev: https://webrevs.openjdk.org/

Re: RFR: 8288568: Reduce runtime of java.security microbenchmarks [v2]

2022-06-17 Thread Claes Redestad
> - Reduce forks, iteration, runtime to reduce runtime while maintaining high > data quality on typical benchmarking hosts. > > Reduces runtime from estimated 10+ hours to 54 minutes. Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8288568: Reduce runtime of java.security microbenchmarks

2022-06-17 Thread Claes Redestad
On Thu, 16 Jun 2022 21:56:40 GMT, Hai-May Chao wrote: > Looks good. Would you also consider to apply the same value or iteration to > PermissionsImplies.java and javax/crypto/Crypto.java? The copyright year for > some of the Oracle files in this PR can be changed to 2022. Thanks! Fixed copyrig

Bug JDK-8176553

2022-06-17 Thread Ricardo Martin Camarero
Hi! I decided to send an email to the security-dev email list as ldap is involved. Please redirect me to other list if it is not the proper audience. The last last days I have faced the same issue that is commented in JDK-8176553 [1]. Although it is cataloged as fixed in 12, the issue is not solv

Re: RFR: JDK-8288475: Initializing RandomGeneratorFactory.FactoryMapHolder fails if a SecurityManager is installed

2022-06-17 Thread Jaikiran Pai
On Fri, 17 Jun 2022 06:50:24 GMT, Johannes Kuhn wrote: >> src/java.base/share/classes/java/util/random/RandomGeneratorFactory.java >> line 165: >> >>> 163: onlyBuiltIn = p -> >>> VM.isSystemDomainLoader(p.type().getClassLoader()); >>> 164: } else { >>> 165:

Re: RFR: JDK-8288475: Initializing RandomGeneratorFactory.FactoryMapHolder fails if a SecurityManager is installed

2022-06-17 Thread Jaikiran Pai
On Fri, 17 Jun 2022 07:10:02 GMT, Johannes Kuhn wrote: > But that is outside the scope of this bug Agreed. I'm not expecting that to be changed in this PR :) It was more a general question about the implementation. - PR: https://git.openjdk.org/jdk/pull/9180

Re: RFR: JDK-8288475: Initializing RandomGeneratorFactory.FactoryMapHolder fails if a SecurityManager is installed

2022-06-17 Thread Johannes Kuhn
On Fri, 17 Jun 2022 07:04:47 GMT, Jaikiran Pai wrote: >> * This adds additional permissions to the jdk.random module >> (`RuntimePermission "accessClassInPackage.jdk.internal.util.random"`) >> * The annotations of the provider classes are now parsed early. >> This avoids putting the parts th

Re: RFR: JDK-8288475: Initializing RandomGeneratorFactory.FactoryMapHolder fails if a SecurityManager is installed

2022-06-17 Thread Jaikiran Pai
On Thu, 16 Jun 2022 07:08:20 GMT, Johannes Kuhn wrote: > * This adds additional permissions to the jdk.random module > (`RuntimePermission "accessClassInPackage.jdk.internal.util.random"`) > * The annotations of the provider classes are now parsed early. > This avoids putting the parts that