Re: RFR: 8282662: Use List.of() factory method to reduce memory consumption [v3]

2022-03-29 Thread Сергей Цыпанов
On Sat, 26 Mar 2022 16:35:14 GMT, liach wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8282662: Revert dubious changes in MethodType > > Just curious, this issue asks to replace set constructions with `Set.of`,

Re: RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor [v7]

2022-03-29 Thread Sean Mullan
On Mon, 28 Mar 2022 22:18:20 GMT, Valerie Peng wrote: >> Can someone help review this update to the PSSParameterSpec class regarding >> the constructor with int argument and the DEFAULT static field? Just added >> @Deprecate javadoc tag and caution about their usage as suggested in the bug >>

Re: "Pluggable" key serialization in JCE/JCA

2022-03-29 Thread Anders Rundgren
On 2022-03-28 21:57, xueleifan(XueleiFan) wrote: Thank you for the information and discussion, Anders, Bernd and Mike.  I had a better understand of JOSE/COSE and the problems. Thanx Xuelei! May I ask a highly related question? Assume there is a new cool XYZ algorithm family supported by a th

Re: [Internet]Re: "Pluggable" key serialization in JCE/JCA

2022-03-29 Thread xueleifan(XueleiFan)
> On Mar 29, 2022, at 10:18 AM, Anders Rundgren > wrote: > > On 2022-03-28 21:57, xueleifan(XueleiFan) wrote: >> Thank you for the information and discussion, Anders, Bernd and Mike. I had >> a better understand of JOSE/COSE and the problems. > > Thanx Xuelei! > May I ask a highly related q

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v12]

2022-03-29 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v13]

2022-03-29 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8281717: Cover logout method for several LoginModule [v3]

2022-03-29 Thread Rajan Halade
On Mon, 28 Mar 2022 06:58:29 GMT, Sibabrata Sahoo wrote: >> test/jdk/com/sun/security/auth/module/AllPlatforms.java line 45: >> >>> 43: UNIX_MODULE, "optional", >>> 44: NT_MODULE, "optional"); >>> 45: login(OS.replaceAll("[^a-zA-Z0-9]", ""), >>> getPlatfo

Re: RFR: 8281717: Cover logout method for several LoginModule [v3]

2022-03-29 Thread Rajan Halade
On Tue, 29 Mar 2022 06:24:16 GMT, Sibabrata Sahoo wrote: >> Added coverage to logout method. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > Update AllPlatforms.java > > Updated exception handling to ignore the case

Re: RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368 [v3]

2022-03-29 Thread Bradford Wetmore
> JDK-8253368 changed the behavior of SSLSocket to no longer throw a fatal > internal_error (80) and invalidate existing sessions (either completed or > under construction) as described in (RFC 4346/TLSv1.1+) if a connection was > closed without receiving a close_notify alert from the peer. >

Re: RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor [v7]

2022-03-29 Thread Valerie Peng
On Tue, 29 Mar 2022 14:08:26 GMT, Sean Mullan wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update again with Sean's wording suggestion. > > src/java.base/share/classes/java/security/spec/PSSParameterSpec.java li

Re: RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor [v8]

2022-03-29 Thread Valerie Peng
> Can someone help review this update to the PSSParameterSpec class regarding > the constructor with int argument and the DEFAULT static field? Just added > @Deprecate javadoc tag and caution about their usage as suggested in the bug > record. > > A CSR will be filed once the wording changes ar

RFR: 8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10

2022-03-29 Thread Alisen Chung
redo of 8280400 - Commit messages: - 8280400: JDK 19 L10n resource files update - msgdrop 10 Changes: https://git.openjdk.java.net/jdk/pull/8026/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8026&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283805 Sta