Hi,
Please review this patch for fixing JDK-8077138.
The solution is re-building NSS libraries with VS2013, and then the new
NSS DLLs can depend on msvcr120.dll, which is already distributed with
JDK 9.
And please note that, this patch also removes the PKCS11 tests from
ProblemList.txt, thoug
Hi,
Please review the patch for,
JBS: https://bugs.openjdk.java.net/browse/JDK-8156054
Webrev: http://cr.openjdk.java.net/~ssahoo/8156054/webrev.00/
Description:
It checks equals(), implies() and hashCode () of FilePermission when
"jdk.io.permissionsUseCanonicalPath" set and un-set.
The code changes look fine (but your webrev shows zero lines changed
throughout).
> On 13 Sep 2016, at 10:43, John Jiang wrote:
>
> Hi,
> Please review this patch for fixing JDK-8077138.
> The solution is re-building NSS libraries with VS2013, and then the new NSS
> DLLs can depend on msvcr12
Hi,
Please review the patch for,
JBS: https://bugs.openjdk.java.net/browse/JDK-8165825
Webrev: http://cr.openjdk.java.net/~ssahoo/8165825/webrev.00/
Description:
This is a simple fix for removing intermittent keyword from
sun/security/krb5/auto/Unreachable.java file.
Thanks,
Si
Change looks fine. Hopefully the test does not fail again. :-)
Thanks
Max
On 9/13/2016 18:43, Sibabrata Sahoo wrote:
Hi,
Please review the patch for,
JBS: https://bugs.openjdk.java.net/browse/JDK-8165825
Webrev: http://cr.openjdk.java.net/~ssahoo/8165825/webrev.00/
Description:
This
44 final String current = ".";
45 final File realFile = new File(current, "exist.file");
I suggest we just use new File("exist.file").
No other comment.
Thanks
Max
On 9/13/2016 18:14, Sibabrata Sahoo wrote:
Hi,
Please review the patch for,
JBS: https://bugs.openjdk.j
Hi,
Please review the patch for,
JBS: https://bugs.openjdk.java.net/browse/JDK-8165660
Webrev: http://cr.openjdk.java.net/~ssahoo/8165660/webrev.00/
Description:
This is a simple fix for removing intermittent keyword from
sun/security/krb5/auto/MaxRetries.java file.
Thanks,
Is there a criteria on when to add and when to remove this keyword? Due
to the characteristics (timeout, ICMP) of these tests, they still have a
chance to fail.
If we keep the keyword there, will it be any bad?
Thanks
Max
On 9/13/2016 18:56, Sibabrata Sahoo wrote:
Hi,
Please review the pa
Hello team,
This is re-request for review of very small changes. Could somebody take
a look?
08.09.16 17:03, Sergei Kovalev wrote:
Hello team,
Could you please review the fix for below CR:
Bug ID: https://bugs.openjdk.java.net/browse/JDK-8165689
WebRev: http://cr.openjdk.java.net/~skovalev
Hi Max,
Here is the updated webrev:
http://cr.openjdk.java.net/~ssahoo/8156054/webrev.01/
Thanks,
Siba
-Original Message-
From: Weijun Wang
Sent: Tuesday, September 13, 2016 4:25 PM
To: Sibabrata Sahoo; [email protected]
Subject: Re: [9] RFR: 8156054: Test Task: Develop new
Good!
Thanks
Max
On 9/13/2016 21:53, Sibabrata Sahoo wrote:
Hi Max,
Here is the updated webrev:
http://cr.openjdk.java.net/~ssahoo/8156054/webrev.01/
Thanks,
Siba
-Original Message-
From: Weijun Wang
Sent: Tuesday, September 13, 2016 4:25 PM
To: Sibabrata Sahoo; security-dev@openjdk
Hello all,
This fixes an issue in OCSP response verification during CertPath
building/verification. This issue happens when trust anchors are used
that were built using constructor forms other than a certificate.
Bug: https://bugs.openjdk.java.net/browse/JDK-8132926
Webrev: http://cr.openjdk
Not really. Will continue with it. I’m not sure whether Alan is done with it
either.
Brian
On Sep 12, 2016, at 8:34 PM, Weijun Wang wrote:
> Have you finished the deeper pass? :-)
>
> Thanks
> Max
>
> On 9/2/2016 8:18, Brian Burkhalter wrote:
>> At the API level and conceptually this all app
I am wondering if we really need to put nss-3.16-with-nspr-4.10.4.tar.gz
in to the repository. Would it be better just to provide a link to this
archive?
Artem
On 09/13/2016 02:43 AM, John Jiang wrote:
Hi,
Please review this patch for fixing JDK-8077138.
The solution is re-building NSS librar
Hi Siba,
I see that the test expects only true or false. You can just pass these
boolean values, and check() can make sure that everything returns the
expected boolean value without building a string. That would be clearer
to me. Not an issue, it's up to you to change it or not.
Artem
On 0
Hello,
Not urgent, but I would appreciate if somebody can take a look at the
webrev below and webvev for 8164591. Thank you!
Artem
On 09/07/2016 02:58 PM, Artem Smotrakov wrote:
Hello,
Please review the following patch for
SSLEngineBadBufferArrayAccess.java test.
The test has been observ
Looks fine to me.
Xuelei
On 9/13/2016 10:47 PM, Jamil Nimeh wrote:
Hello all,
This fixes an issue in OCSP response verification during CertPath
building/verification. This issue happens when trust anchors are used
that were built using constructor forms other than a certificate.
Bug: https:/
I think the failure may caused by using free port by other test cases.
As you were already there, would you mind update to use the
SSLSocketSample.java template under the folder test/javax/net/ssl/templates?
Thanks,
Xuelei
On 9/14/2016 9:31 AM, Artem Smotrakov wrote:
Hello,
Not urgent, but I
18 matches
Mail list logo
