Re: RFR 8164705: Remove pathname canonicalization from FilePermission

2016-09-12 Thread Weijun Wang
BTW, please also review the release note at https://bugs.openjdk.java.net/browse/JDK-8165836 Thanks Max On 9/1/2016 22:25, Weijun Wang wrote: Webrev updated at http://cr.openjdk.java.net/~weijun/8164705/webrev.01

Re: RFR 8164705: Remove pathname canonicalization from FilePermission

2016-09-12 Thread Brian Burkhalter
Only picky comments: not sure but maybe change: 1) vice versa -> and vice versa 2) When it’s set to true -> When true 3) just like before -> as before Brian On Sep 12, 2016, at 12:23 AM, Weijun Wang wrote: > BTW, please also review the release note at > > https://bugs.openjdk.java.net/brows

Re: RFR 8164705: Remove pathname canonicalization from FilePermission

2016-09-12 Thread Weijun Wang
On 9/13/2016 2:13, Brian Burkhalter wrote: Only picky comments: not sure but maybe change: 1) vice versa -> and vice versa 2) When it’s set to true -> When true 3) just like before -> as before All accepted. Thanks Max Brian On Sep 12, 2016, at 12:23 AM, Weijun Wang mailto:weijun.w...@o

Re: RFR 8164705: Remove pathname canonicalization from FilePermission

2016-09-12 Thread Weijun Wang
Have you finished the deeper pass? :-) Thanks Max On 9/2/2016 8:18, Brian Burkhalter wrote: At the API level and conceptually this all appears reasonable. I am going to need to take a deeper pass over it all however to comprehend the implementation at any kind of detailed level. The changes men