RFR 8130022: Use Java-style array declarations consistently

2015-07-08 Thread Ivan Gerasimov
Hello! We've got a request to fix javadoc for SecureRandom, so that the example code will read byte[] bytes = new byte[20]; instead of byte bytes[] = new byte[20]; I took opportunity to make all array declarations throughout security-lib source code more of Java-style. Would you please help

Re: RFR 8130022: Use Java-style array declarations consistently

2015-07-08 Thread Seán Coffey
Looks good to me.. and is much easier to read now! Regards, Sean. On 08/07/2015 16:35, Ivan Gerasimov wrote: Hello! We've got a request to fix javadoc for SecureRandom, so that the example code will read byte[] bytes = new byte[20]; instead of byte bytes[] = new byte[20]; I took opportunity

Re: RFR 8130022: Use Java-style array declarations consistently

2015-07-08 Thread Ivan Gerasimov
On 08.07.2015 18:57, Seán Coffey wrote: Looks good to me.. and is much easier to read now! Thanks Seán for review! I've missed some portion of update int the previous webrev. Now, sending the whole changeset: http://cr.openjdk.java.net/~igerasim/8130022/01/webrev/ Would you please take an

Re: RFR 8130022: Use Java-style array declarations consistently

2015-07-08 Thread Ivan Gerasimov
On 08.07.2015 18:57, Seán Coffey wrote: Looks good to me.. and is much easier to read now! Thanks Seán for review! I've missed some portion of update int the previous webrev. Now, sending the whole changeset: http://cr.openjdk.java.net/~igerasim/8130022/01/webrev/ Would you please take an

Re: RFR 8130022: Use Java-style array declarations consistently

2015-07-08 Thread Seán Coffey
On 08/07/2015 18:14, Ivan Gerasimov wrote: On 08.07.2015 18:57, Seán Coffey wrote: Looks good to me.. and is much easier to read now! Thanks Seán for review! I've missed some portion of update int the previous webrev. Now, sending the whole changeset: http://cr.openjdk.java.net/~igerasim/8

Re: Code Review Request: JDK-8130460 Increase the stability of DTLS test CipherSuite.java

2015-07-08 Thread Xuelei Fan
ping ... Xuelei On 7/6/2015 9:11 AM, Xuelei Fan wrote: > Hi, > > Please review this simple fix. > >http://cr.openjdk.java.net/~xuelei/8130460/webrev.00/ > > The DTLS test, javax/net/ssl/DTLS/CipherSuite.java, failed in nightly > regression intermittent. In the test, it only allows 10 time

TLS ALPN Proposal v3

2015-07-08 Thread Bradford Wetmore
Greetings, Xuelei wrote: > I think Brad would consider our information for his design. I did, and thanks for the all of the detailed discussion, Simone/Michael/Xuelei. I've taken into account the feedback from the previous discussion back in June. Here is v3 of the public ALPN API. ht

Re: Code Review Request: JDK-8130460 Increase the stability of DTLS test CipherSuite.java

2015-07-08 Thread Bradford Wetmore
Looks good. Brad On 7/8/2015 4:24 PM, Xuelei Fan wrote: ping ... Xuelei On 7/6/2015 9:11 AM, Xuelei Fan wrote: Hi, Please review this simple fix. http://cr.openjdk.java.net/~xuelei/8130460/webrev.00/ The DTLS test, javax/net/ssl/DTLS/CipherSuite.java, failed in nightly regression int

[9] RFR: 8049814: Additional SASL client-server tests

2015-07-08 Thread Artem Smotrakov
Hello, Please review a client/server test for SASL which uses different mechanisms and QOPs. Bug: https://bugs.openjdk.java.net/browse/JDK-8049814 Webrev: http://cr.openjdk.java.net/~asmotrak/8049814/webrev.00/ Artem

Re: TLS ALPN Proposal v3

2015-07-08 Thread Xuelei Fan
On 7/9/2015 7:42 AM, Bradford Wetmore wrote: > Xuelei/Simone wrote: >>> Per my understanding, application protocol should be negotiated before >>> cipher suite and protocol version negotiated. >> >> This is not possible for HTTP/2. >> Application protocol negotiation MUST happen *after* the TLS pro

Re: RFR: (s) 8130696: Security Providers need to have their version numbers updated for JDK 9

2015-07-08 Thread Valerie Peng
Is the Verona repo sync'ed to the latest OpenJDK? The webrev seems to be missing the provider JdkSASL inside the following file src/jdk.security.jgss/share/classes/com/sun/security/sasl/gsskerb/JdkSASL.java The rest looks good. Valerie On 7/7/2015 10:48 AM, Iris Clark wrote: Hi. Please revi

Re: RFR: (s) 8130696: Security Providers need to have their version numbers updated for JDK 9

2015-07-08 Thread Weijun Wang
Hi Iris The change to S11N.java looks fine. Thanks Max On 07/08/2015 01:48 AM, Iris Clark wrote: Hi. Please review changes to resolve the following bug: 8130696: Security Providers need to have their version numbers updated for JDK 9 (Verona) Bug: https://bugs.openjdk.java.net/browse/JDK-81