Thanks for the review Kevin!
> > +struct mutex_s usb_hid_lock;
>
> What is this lock for? The "thread" implementation in SeaBIOS is
> cooperative, so I don't see how the code could be preempted between
> lock/unlock anyway. Maybe I'm missing something.
>
Good question. I'm not the most versed i
On Tue, Nov 12, 2024 at 12:33:58PM +0100, Gerd Hoffmann wrote:
> We already have a runtime config switch to force 32-bit friendly setup
> (turn off long mode support in the vcpu).
>
> We already have a heuristic to select the 32-bit friendly setup, which
> right now is simply "no memory above 4G i
On Sun, Oct 27, 2024 at 08:53:45AM +, Daniel Khodabakhsh wrote:
> From 354935deae7cb79ee9a400222ed950314694194a Mon Sep 17 00:00:00 2001
> From: Daniel Khodabakhsh
> Date: Sat, 26 Oct 2024 04:18:49 -0700
> Subject: [PATCH] Support multiple USB HID devices by storing them in a linked
> list.
>
On Thu, Nov 14, 2024 at 02:54:38PM +0100, Gerd Hoffmann wrote:
> On Wed, Nov 13, 2024 at 11:14:28AM +, Daniel Khodabakhsh wrote:
> > Hi Gerd,
> >
> > Thanks for the reviews!
> >
> > >
> > > seabios has a linked list implementation (see src/list.h).
> > > Please use that instead of rolling you
> How about adding this line to the start of the pci_resume() function?
I see no problem with this. However, I cannot test this for around a week
or two.
I will get back to you as soon as I can test this.
Sincerely,
Omar.
On Tue., Nov. 12, 2024, 4:02 p.m. Gerd Hoffmann, wrote:
> On Sat, Nov 02
On Wed, Nov 13, 2024 at 11:14:28AM +, Daniel Khodabakhsh wrote:
> Hi Gerd,
>
> Thanks for the reviews!
>
> >
> > seabios has a linked list implementation (see src/list.h).
> > Please use that instead of rolling your own.
> >
> > Otherwise the patch looks sane on a quick glance.
> >
>
> Thank
