[SeaBIOS] [PATCH v4] Add basic MXM 3.0 interrupt support

2024-04-14 Thread Riku Viitanen via SeaBIOS
VGAROMs on MXM graphics cards need certain int15h functions present to function properly. On HP EliteBook 8560w with coreboot and Quadro 2000M, this warning is displayed for 30 seconds, making every boot extremely slow: ERROR: Valid MXM Structure not found POST halted for 30 seconds, P-st

[SeaBIOS] Re: [PATCH v4] Add basic MXM 3.0 interrupt support

2024-04-14 Thread Kevin O'Connor
On Sun, Apr 14, 2024 at 10:30:55AM +, Riku Viitanen via SeaBIOS wrote: > VGAROMs on MXM graphics cards need certain int15h functions present > to function properly. > > On HP EliteBook 8560w with coreboot and Quadro 2000M, this warning > is displayed for 30 seconds, making every boot extremely

[SeaBIOS] Re: [PATCH v4] Add basic MXM 3.0 interrupt support

2024-04-14 Thread Kevin O'Connor
On Sun, Apr 14, 2024 at 11:51:33AM -0400, Kevin O'Connor wrote: > On Sun, Apr 14, 2024 at 10:30:55AM +, Riku Viitanen via SeaBIOS wrote: > > VGAROMs on MXM graphics cards need certain int15h functions present > > to function properly. > > > > On HP EliteBook 8560w with coreboot and Quadro 2000

[SeaBIOS] Re: [PATCH v4] Add basic MXM 3.0 interrupt support

2024-04-14 Thread Riku Viitanen via SeaBIOS
> Ah, I missed that vgahook_setup() checks for NULL. Out of curiosity, > is it possible to limit this support to a particular hardware vendor > instead of by existence of file? ATI, AMD, and Nvidia based MXM cards exist. I don't know of a way to probe it to find out if it's an MXM format card. And

[SeaBIOS] Re: [PATCH v4] Add basic MXM 3.0 interrupt support

2024-04-14 Thread Riku Viitanen via SeaBIOS
> I think it would be preferable if mxm_setup() was passed the pci > device for uniformity, and have mxm_setup() call romfile_xxx() itself. Do you mean, run mxm30_setup unconditionally? And it checks if the file exists: else if (mxm30_setup(pci)) /* nothing left to do here */

[SeaBIOS] Re: [PATCH v4] Add basic MXM 3.0 interrupt support

2024-04-14 Thread Kevin O'Connor
On Sun, Apr 14, 2024 at 05:39:21PM +, Riku Viitanen wrote: > > Ah, I missed that vgahook_setup() checks for NULL. Out of curiosity, > > is it possible to limit this support to a particular hardware vendor > > instead of by existence of file? > > ATI, AMD, and Nvidia based MXM cards exist. I do

[SeaBIOS] Re: [PATCH v4] Add basic MXM 3.0 interrupt support

2024-04-14 Thread Kevin O'Connor
On Sun, Apr 14, 2024 at 05:56:31PM +, Riku Viitanen wrote: > > I think it would be preferable if mxm_setup() was passed the pci > > device for uniformity, and have mxm_setup() call romfile_xxx() itself. > > Do you mean, run mxm30_setup unconditionally? > And it checks if the file exists: > >

[SeaBIOS] Re: [RESEND PATCH] fw/pciinit: don't misalign large BARs

2024-04-14 Thread Daniil Tatianin
Hey there! Do we need more reviewed-bys before this can be merged? Thanks! On 4/11/24 10:51 PM, Daniil Tatianin wrote: Previously we would unconditionally lower the alignment for large BARs in case their alignment was greater than "pci_mem64_top >> 11", this would make it impossible to use the