[SeaBIOS] Re: [PATCH 0/9] Improve comments in stdvga.c

2024-04-09 Thread Kevin O'Connor
On Mon, Apr 01, 2024 at 11:51:22AM -0400, Kevin O'Connor wrote: > This series adds comments to vgasrc/stdvga.c along with some variable > and function renaming. The goal is to make it a little easier to > understand this legacy code. > > There should be no functionality changes with this patch se

[SeaBIOS] Re: [PATCH] stdvga: Add stdvga_set_vertical_size() helper function

2024-04-09 Thread Kevin O'Connor
On Tue, Apr 02, 2024 at 02:35:05PM -0400, Kevin O'Connor wrote: > Add helper function and update the bochsvga.c code to use it. This > emphasizes the relationship between stdvga_get_vertical_size() and > stdvga_set_vertical_size() code. > > Signed-off-by: Kevin O'Connor I committed this patch.

[SeaBIOS] [PATCH] stdvgaio: Only read/write one color palette entry at a time

2024-04-09 Thread Kevin O'Connor
Introduce stdvga_dac_read_many() and stdvga_dac_write_many() for writing multiple dac palette entries. Convert the stdvga_dac_read() and stdvga_dac_write() low-level IO access functions in stdvgaio.c to access just one color palette entry. Signed-off-by: Kevin O'Connor -- There should not be an

[SeaBIOS] Re: [PATCH] stdvgaio: Only read/write one color palette entry at a time

2024-04-09 Thread Daniel Verkamp
On Tue, Apr 9, 2024 at 8:20 AM Kevin O'Connor wrote: > > Introduce stdvga_dac_read_many() and stdvga_dac_write_many() for > writing multiple dac palette entries. Convert the stdvga_dac_read() > and stdvga_dac_write() low-level IO access functions in stdvgaio.c to > access just one color palette e