> I think it would be preferable if mxm_setup() was passed the pci
> device for uniformity, and have mxm_setup() call romfile_xxx() itself.
Do you mean, run mxm30_setup unconditionally?
And it checks if the file exists:
else if (mxm30_setup(pci))
/* nothing left to do here */
> Ah, I missed that vgahook_setup() checks for NULL. Out of curiosity,
> is it possible to limit this support to a particular hardware vendor
> instead of by existence of file?
ATI, AMD, and Nvidia based MXM cards exist. I don't know of a way to
probe it to find out if it's an MXM format card. And
VGAROMs on MXM graphics cards need certain int15h functions present
to function properly.
On HP EliteBook 8560w with coreboot and Quadro 2000M, this warning
is displayed for 30 seconds, making every boot extremely slow:
ERROR: Valid MXM Structure not found
POST halted for 30 seconds, P-st
> I'd suggest to add a romfile_loadfile_low()
I can definitely do that.
> or add a 'struct zone_s'
> parameter instead of passing in a function pointer.
Sounds sensible. I see there's a malloc that takes zone as argument.
> Also: What the trailing bytes are used for?
Only for re-implementing t
VGAROMs on MXM graphics cards need certain int15h functions present.
Tested on a HP EliteBook 8560w with coreboot and Quadro 2000M. A warning
is displayed for 30 seconds and performance is nerfed:
ERROR: Valid MXM Structure not found.
POST halted for 30 seconds, P-state limited to
romfile_loadfile_g:
Based on romfile_loadfile but more flexible. User has to supply pointer
to a malloc function and the number of trailing padding bytes. Thus, any
memory region may be used.
romfile_loadfile:
It is now a wrapper around romfile_loadfile_g. Functionality is the same.
Signed-off-by
