Re: [screen-devel] screen review

2011-01-17 Thread Steve Grubb
On Monday, January 17, 2011 08:42:22 am Miroslav Lichvar wrote: > patch 1: not checking return code from setgid/setuid can lead to > vulnerabilities, see CVE-2006-2607 Yes and I think under at least one code path and perhaps some compile options, a failure in setuid would let an arbitrary progra

Re: [screen-devel] screen review

2011-01-17 Thread Miroslav Lichvar
On Sat, Jan 15, 2011 at 10:15:22AM -0800, Sadrul Habib Chowdhury wrote: > On Thu, Jan 13, 2011 at 8:59 AM, Miroslav Lichvar wrote: > > attached are some patches for issues found in a screen review, please > > consider for inclusion. > > > Hi! Thanks for the patches. Perhaps you could briefly explai

Re: [screen-devel] screen review

2011-01-15 Thread Sadrul Habib Chowdhury
On Thu, Jan 13, 2011 at 8:59 AM, Miroslav Lichvar wrote: > Hi, > > attached are some patches for issues found in a screen review, please > consider for inclusion. > > Hi! Thanks for the patches. Perhaps you could briefly explain what each patch does (e.g. what bugs they fix etc.)? Cheers. Sadrul