Re: [screen-devel] [PATCH for screen-v4] Fix screen leaving zombie processes

2019-11-22 Thread Axel Beckert
Hi Amadeusz, sorry for the late reply. Didn't find the time to try the new patch on that affected production VM earlier. On Wed, Nov 06, 2019 at 09:11:08PM +0100, Amadeusz Sławiński wrote: > > I am wondering why the zombies show up at all. Me too. > > They were reaped correctly on my test proce

Re: [screen-devel] [PATCH for screen-v4] Fix screen leaving zombie processes

2019-11-06 Thread Amadeusz Sławiński
On Wed, 6 Nov 2019 21:11:08 +0100 Amadeusz Sławiński wrote: > On Wed, 6 Nov 2019 15:12:41 +0100 > Václav Doležal wrote: > > > I think this is bad solution. If some process deliberately closes stdout and > > stderr, screen will block until that process exits. > > > > I am wondering why the zomb

Re: [screen-devel] [PATCH for screen-v4] Fix screen leaving zombie processes

2019-11-06 Thread Amadeusz Sławiński
On Wed, 6 Nov 2019 15:12:41 +0100 Václav Doležal wrote: > I think this is bad solution. If some process deliberately closes stdout and > stderr, screen will block until that process exits. > > I am wondering why the zombies show up at all. They were reaped correctly on > my test process (code be

Re: [screen-devel] [PATCH for screen-v4] Fix screen leaving zombie processes

2019-11-06 Thread Václav Doležal
I think this is bad solution. If some process deliberately closes stdout and stderr, screen will block until that process exits. I am wondering why the zombies show up at all. They were reaped correctly on my test process (code below). I guess there is some race with SIGCHLD handler. Regards, Vác

Re: [screen-devel] [PATCH for screen-v4] Fix screen leaving zombie processes

2019-11-02 Thread Amadeusz Sławiński
On Sun, 3 Nov 2019 00:17:21 +0100 Axel Beckert wrote: > So thanks again for the patch and for applying it in git, too. Well, it's not applied yet, I decided to change a bit my model of work, to send patches to the list first and wait a bit for comments (around one week.) If no one tells me that

Re: [screen-devel] [PATCH for screen-v4] Fix screen leaving zombie processes

2019-11-02 Thread Axel Beckert
Hi Amadeusz, On Sat, Nov 02, 2019 at 10:59:44PM +0100, Amadeusz Sławiński wrote: > When window dies we should wait for child process to die, otherwise > there is no one to reap it. > > So emove WNOHANG in waitpid(), which may cause screen to not wait for > child to die and kill window, leaving zo

[screen-devel] [PATCH for screen-v4] Fix screen leaving zombie processes

2019-11-02 Thread Amadeusz Sławiński
When window dies we should wait for child process to die, otherwise there is no one to reap it. So emove WNOHANG in waitpid(), which may cause screen to not wait for child to die and kill window, leaving zombie process. Bug: 25089 Signed-off-by: Amadeusz Sławiński --- src/screen.c | 2 +- 1 fi