Re: [PATCH 3/3] Add login by email address and revise some messages to the user in Savane

2020-12-10 Thread Ian Kelling
Hi Andrea. Thanks for sending these patches, but I think you are missing a description of why you made these changes. It seems like a lot of them are fairly trivial language changes. Why should someone apply these changes?

Re: [PATCH 3/3] Add login by email address and revise some messages to the user in Savane

2020-12-10 Thread Andrea G. Monaco
Hi Ian! Thanks for your review. Maybe a little explanation will help. The most important change in my patches is letting the user log in by mail address, which is looked for in the database if the login field doesn't match anything. It happened to me to forget my user name and I think it's not t

Re: [PATCH 3/3] Add login by email address and revise some messages to the user in Savane

2020-12-10 Thread Ineiev
On Fri, Dec 11, 2020 at 04:19:33AM +0100, Andrea G. Monaco wrote: > > Maybe a little explanation will help. The most important change in my > patches is letting the user log in by mail address, which is looked for > in the database if the login field doesn't match anything. It happened > to me t