Re: [PATCH 3/3] Add login by email address and revise some messages to the user in Savane

2020-12-15 Thread Ineiev
On Fri, Dec 11, 2020 at 02:57:10PM +0100, Andrea G. Monaco wrote: > > As a matter of fact, people rarely forget their logins---typically, > > they forget their passwords and lose email accounts; when they do > > forget their logins, the admins process their requests quite fast. > > True, but

Re: [PATCH 3/3] Add login by email address and revise some messages to the user in Savane

2020-12-11 Thread Andrea G. Monaco
Hi, > As a matter of fact, people rarely forget their logins---typically, > they forget their passwords and lose email accounts; when they do > forget their logins, the admins process their requests quite fast. True, but it does happen. The patch would avoid admins' involvement and save ti

Re: [PATCH 3/3] Add login by email address and revise some messages to the user in Savane

2020-12-10 Thread Ineiev
On Fri, Dec 11, 2020 at 04:19:33AM +0100, Andrea G. Monaco wrote: > > Maybe a little explanation will help. The most important change in my > patches is letting the user log in by mail address, which is looked for > in the database if the login field doesn't match anything. It happened > to me t

Re: [PATCH 3/3] Add login by email address and revise some messages to the user in Savane

2020-12-10 Thread Andrea G. Monaco
Hi Ian! Thanks for your review. Maybe a little explanation will help. The most important change in my patches is letting the user log in by mail address, which is looked for in the database if the login field doesn't match anything. It happened to me to forget my user name and I think it's not t

Re: [PATCH 3/3] Add login by email address and revise some messages to the user in Savane

2020-12-10 Thread Ian Kelling
Hi Andrea. Thanks for sending these patches, but I think you are missing a description of why you made these changes. It seems like a lot of them are fairly trivial language changes. Why should someone apply these changes?

[PATCH 3/3] Add login by email address and revise some messages to the user in Savane

2020-11-30 Thread Andrea G. Monaco
frontend/php/account/register.php | 2 +- frontend/php/include/account.php | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/frontend/php/account/register.php b/frontend/php/account/register.php index 5116ab4..882d5cc 100644 --- a/frontend/php/account/register.php