Hi Luiz,
Thanks for the patch. LGTM with the exception of the manual page and a
typo in the -h output. I've fixed the typo and brushed up the manual
page's OPTIONS section and pushed the lot.
# I've only reviewed your patch and did not actually test anything.
Hope this helps,
--
Olaf Meeuwisse
From: Luiz Angelo Daros de Luca
Flags like -a, -d and -s have many overlap effects. This patch restricts
the effect of flags to a simple action.
New -u (user) flag replaces -a optional argument for running saned as a
different user.
The code that retrieve the user info and drop privileges migra
Feel free to update the NEWS file, I'll incorporate your changes when
we ship 1.0.28
allan
On Sun, Sep 10, 2017 at 6:55 PM, Luiz Angelo Daros de Luca
wrote:
> Hi Olaf,
>
>> Apologies for the late follow-up. Shame on me for pinging you on the
>> bug report for no follow-up for a long time and th
Hi Olaf,
Apologies for the late follow-up. Shame on me for pinging you on the
> bug report for no follow-up for a long time and then ignoring it when
> you promptly send some. :-(
>
>
No apologies needed. We know how it works.
I was just waiting for your reply. My changes were already at github
Hi Luiz,
Apologies for the late follow-up. Shame on me for pinging you on the
bug report for no follow-up for a long time and then ignoring it when
you promptly send some. :-(
Luiz Angelo Daros de Luca writes:
> Hi Olaf,
>
>> Doing the saned options the Unix way? Great, "Do just one thing" bu
Hi Olaf,
>
> Doing the saned options the Unix way? Great, "Do just one thing" but
> let's also have a look at the "and do it well" part. This is not to
> imply that your patch is not doing things well, btw, just a little
> reminder that that is also part of the Unix way.
>
> > All flags now do o
Hi Vadim,
Thanks for the patch.
@Allan> Since you're listed as the canon_dr backend's author, can you
take a look at this?
Vadim V. Vlasov writes:
> The patch adds support for batch count by introducing "--batchMode=XX"
> parameter. This works at least with Canon DR-G1100 but may also
>
The patch adds support for batch count by introducing "--batchMode=XX"
parameter. This works at least with Canon DR-G1100 but may also
work with other scanners. At least it should not break current
behaviour (as long as you do not use "--batchMode=XX").
Note, what you call "SSM2_BUFF_sync" is, pro
Hi Luiz,
Thanks for your patches. I really appreciate that you also keep the
documentation in sync!
Luiz Angelo Daros de Luca writes:
> The two first patches are trivial bugfixes.
Indeed they are and I'll push them shortly.
> However, this one proposes a new organization on saned options, as
The two first patches are trivial bugfixes. However, this one proposes a
new organization
on saned options, as shown at:
https://alioth.debian.org/tracker/index.php?func=detail&aid=315747&group_id=30186&atid=410366
All flags now do one thing and normally have an opposite flag that can
deactivate
From: Luiz Angelo Daros de Luca
Flags like -a, -d and -s have many overlap effects. This patch restricts
the effect of flags to a simple action.
New -u (user) flag replaces -a optional argument for running saned as a
different user.
The code that retrieve the user info and drop privileges migra
From: Luiz Angelo Daros de Luca
---
doc/saned.man | 9 +
1 file changed, 9 insertions(+)
diff --git a/doc/saned.man b/doc/saned.man
index 34764f1f..8542d254 100644
--- a/doc/saned.man
+++ b/doc/saned.man
@@ -6,6 +6,9 @@ saned \- SANE network daemon
.B saned
.B [ \-a
.I [ username ]
+
From: Luiz Angelo Daros de Luca
Man page was correct.
Signed-off-by: Luiz Angelo Daros de Luca
---
frontend/saned.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/frontend/saned.c b/frontend/saned.c
index 2fc33216..6b97e914 100644
--- a/frontend/saned.c
+++ b/frontend/sane
Hello,
It's could be out of topic for MF240, but all allowed resolutions
(75/150/300/600dpi) tested give me good results with the new supported
MF230 series (MF232w).
Regards
Le vendredi 19 mai 2017 à 10:36 +0200, Rolf Bensch a écrit :
> Hello,
>
> I just got a report from a MF240 Series scanne
Hello,
I just got a report from a MF240 Series scanner that only 300dpi is
possible (allowed) scanning from the document feeder. Please test this
and report your results.
Many thanks for your help in advance.
Cheers,
Rolf
Am 26.04.2017 um 11:51 schrieb Rolf Bensch:
>
> Hello,
>
> I just commit
Hi Klaus,
Klaus Kaempf writes:
> * Olaf Meeuwissen [May 04. 2017 12:03]:
>>
>> Thanks for the patch, it looks good so I'll push it but shouldn't you
>> list the ProScan 10T and Reflecta CrystalScan 3600 as supported to at
>> least some extent in doc/descriptions/pieusb.desc now?
>>
>> Waiting fo
* Olaf Meeuwissen [May 04. 2017 12:03]:
>
> Thanks for the patch, it looks good so I'll push it but shouldn't you
> list the ProScan 10T and Reflecta CrystalScan 3600 as supported to at
> least some extent in doc/descriptions/pieusb.desc now?
>
> Waiting for your doc-fix ;-)
Attached ;-)
Thank
Hi Klaus,
Klaus Kaempf writes:
> Neither of these scanner have an automated slide transport and fail on
> respective SCSI commands.
>
> - Add flags parameter to control if automatic slide transport is available
> - Reflect flags in pieusb.conf.in
> - rename SLIDE_LAMP_ON to SLIDE_INIT
> it fail
Hi Aaron,
Thanks, I pushed your patch in 801558f.
--
Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13 F43E B8A4 A88A F84A 2DD9
Support Free Softwarehttps://my.fsf.org/donate
Join the Free Software Foun
Hi Aaron
Aaron Muir Hamilton writes:
> I just tried it by hacking scanimage up a bit to threshhold and convert
> the lines to monochrome right before writing the PNG, and change the PNG
> header to always be 1-bit; libpng didn't complain about attaching a
> grayscale profile to a 1-bit monochrome
Neither of these scanner have an automated slide transport and fail on
respective SCSI commands.
- Add flags parameter to control if automatic slide transport is available
- Reflect flags in pieusb.conf.in
- rename SLIDE_LAMP_ON to SLIDE_INIT
it fails on scanners without automatic slide transpor
I just tried it by hacking scanimage up a bit to threshhold and convert
the lines to monochrome right before writing the PNG, and change the PNG
header to always be 1-bit; libpng didn't complain about attaching a
grayscale profile to a 1-bit monochrome image.
--
sane-devel mailing list: sane-deve
> Olaf Meeuwissen writes:
> Hi Aaron,
>
> I'm working on your ICC profile patches but this one made me wonder what
> happens with monochrome scans, i.e. grayscale with a bit depth of one.
Unfortunately, 1-bit images are not supported by genesys, and I don't
think I have any other scanners set up t
---
frontend/scanimage.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/frontend/scanimage.c b/frontend/scanimage.c
index ffb9f105..e5562815 100644
--- a/frontend/scanimage.c
+++ b/frontend/scanimage.c
@@ -1213,7 +1213,7 @@ write_png_header (SANE_Frame format, i
Hi Aaron,
Aaron Muir Hamilton writes:
> Pleased to make your acquaintance, Olaf.
Same here.
> Thank you for reviewing the patches and taking them upstream,
> I have an equivalent patch for JPEG output on the boil.
Good. You have until 2017-05-07 to get it in the next release.
> Not to put yo
Hi Aaron,
I'm working on your ICC profile patches but this one made me wonder what
happens with monochrome scans, i.e. grayscale with a bit depth of one.
If that works fine, I'll push your patches with two fixes after merging
against master.
Aaron Muir Hamilton writes:
> If the ICC profile add
Pleased to make your acquaintance, Olaf.
Thank you for reviewing the patches and taking them upstream,
I have an equivalent patch for JPEG output on the boil.
Not to put you on the spot, but it seems like a lot of time has passed
since the last release was tagged, despite there apparently being
Hi Aaron,
Sorry for not reading your whole thread before replying ;-)
Aaron Muir Hamilton writes:
> Sorry about the volume, third time is definitely the charm.
> Admittedly I struggled to grasp the style rules.
Style rules? If there are any, they're at a per file basis AFAICS :-(
Which reminds
Hi Aaron,
Thanks for the patch but it is incorrect on big-endian architectures.
>From 3.2.1 Image Transmission in the SANE API specification:
Conceptually, each frame is transmitted a byte at a time. Each byte
may contain 8 sample values (for an image bit depth of 1), one full
sample value
Hi Aaron,
Thanks for the patch. It's on its way to the Alioth repository.
Bonus points for a similar patch for JPEG "densities". TIFF is already
been taken care of.
Hope this helps,
--
Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
GnuPG key: F84A2DD9/B3C0 2F47 EA19 6
Hello,
I just committed the patch to the git repository (pixma backend version
>= 0.17.36) and updated the doc files. I also added the new scanners
i-SENSYS MF240 Series
Many thanks for your help.
Cheers,
Rolf
Am 19.04.2017 um 21:47 schrieb Peter Talbott:
>
> Hello,
>
> I also have a Canon Imag
Hello,
I also have a Canon ImageClass MF232.
I added that patch into the pixma_imageclass.c file, recompiled the sane
backeneds and it seems to work perfectly.
Thank You!
On 04/17/2017 01:54 PM, thierry wrote:
Hello,
This little patch add support to Canon MF230 Series scanner.
Tested OK (ne
Hello,
This little patch add support to Canon MF230 Series scanner.
Tested OK (network only) on my MF232w :
[bjnp] get_scanner_id: Scanner identity string =
MFG:CANON;CMD:MFNP1,MultiPASS 2.1;MDL:Canon MF230
Series;CLS:IMG;DES:Canon MF230 Series; - length = 88
[bjnp] get_scanner_id: Scanner model =
This cuts out some duplicate code, and enables us to reuse this
logic for PNG, JPEG, and any other future output format.
sanei_load_icc_profile also allows us to know that an ICC profile
file is not long enough before we start to write it to the output;
this should prevent poorly-written
If the ICC profile added does not match the colour format of the
image, libpng will abort. This can leave the scanner motors in an
incorrect state and possibly cause permanent damage.
---
frontend/scanimage.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff
---
frontend/scanimage.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/frontend/scanimage.c b/frontend/scanimage.c
index 77c22883..0f71422c 100644
--- a/frontend/scanimage.c
+++ b/frontend/scanimage.c
@@ -56,6 +56,7 @@
#include "../include/sane/sanei.h
This cuts out some duplicate code, and enables us to reuse this
logic for PNG, JPEG, and any other future output format.
sanei_load_icc_profile also allows us to know that an ICC profile
file is not long enough before we start to write it to the output;
this should prevent poorly-written
---
frontend/scanimage.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/frontend/scanimage.c b/frontend/scanimage.c
index 77c2288..0f71422 100644
--- a/frontend/scanimage.c
+++ b/frontend/scanimage.c
@@ -56,6 +56,7 @@
#include "../include/sane/sanei.h"
---
frontend/scanimage.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/frontend/scanimage.c b/frontend/scanimage.c
index 77c2288..0f71422 100644
--- a/frontend/scanimage.c
+++ b/frontend/scanimage.c
@@ -56,6 +56,7 @@
#include "../include/sane/sanei.h"
This cuts out some duplicate code, and enables us to reuse this
logic for PNG, JPEG, and any other future output format.
sanei_load_icc_profile also allows us to know that an ICC profile
file is not long enough before we start to write it to the output;
this should prevent poorly-written
---
frontend/scanimage.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/frontend/scanimage.c b/frontend/scanimage.c
index 77c2288..432c2ea 100644
--- a/frontend/scanimage.c
+++ b/frontend/scanimage.c
@@ -1165,9 +1165,12 @@ write_pnm_header (SANE_Frame format,
Sorry about the volume, third time is definitely the charm.
Admittedly I struggled to grasp the style rules.
I noticed the PNG byte order issue fixed by this patch when using
genesys with a CanoScan LiDE 220. I do not have any other supported
scanners close at hand, so I hope somebody can confirm
---
frontend/scanimage.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/frontend/scanimage.c b/frontend/scanimage.c
index 77c2288..0925039 100644
--- a/frontend/scanimage.c
+++ b/frontend/scanimage.c
@@ -1529,6 +1529,19 @@ scan_it (FILE *ofp)
for(j = 0
---
frontend/scanimage.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/frontend/scanimage.c b/frontend/scanimage.c
index 77c2288..961ca49 100644
--- a/frontend/scanimage.c
+++ b/frontend/scanimage.c
@@ -1529,6 +1529,19 @@ scan_it (FILE *ofp)
for(j = 0
---
frontend/scanimage.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/frontend/scanimage.c b/frontend/scanimage.c
index 77c2288..d719c4b 100644
--- a/frontend/scanimage.c
+++ b/frontend/scanimage.c
@@ -1529,6 +1529,19 @@ scan_it (FILE *ofp)
for(j =
Hello Rolf,
No, unfortunately I have only MF5730 and it already has status 'completed'.
On 5 October 2016 at 21:15, Rolf Bensch wrote:
> Hello Dmitry,
>
> I just pushed your patch to SANEs git repository.
>
> The MF5750 still has the status untested. Have you also tested this
> device or can yo
Hello Dmitry,
I just pushed your patch to SANEs git repository.
The MF5750 still has the status untested. Have you also tested this
device or can you confirm that this device is working?
Many thanks for your help.
Cheers,
Rolf
Am 30.09.2016 um 15:38 schrieb Dmitry Deshevoy:
> Canon MF57x0 devi
Canon MF57x0 devices require abort_session() after each page except
the last one.
The result from calibrate() should be ignored, so that scanning is not
interrupted with PIXMA_STATUS_BUSY.
---
backend/pixma_mp730.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletion
Yurii Kolesnykov writes:
> Hi, Olaf!
>
>
> На 27 червня 2016 р. в 15:22:49, Olaf Meeuwissen
> (paddy-h...@member.fsf.org) написав:
>> Hi Yurii,
>>…
>
>> Thanks for pointing this out.
>>
>> I've reviewed all the links and pushed a slightly different patch. It
>> aims to provide a more consistent s
Hi, Olaf!
На 27 червня 2016 р. в 15:22:49, Olaf Meeuwissen
(paddy-h...@member.fsf.org) написав:
> Hi Yurii,
> …
> Thanks for pointing this out.
>
> I've reviewed all the links and pushed a slightly different patch. It
> aims to provide a more consistent set of URLs.
>
> Hope you don't mind,
I
Hi Yurii,
yuriko...@gmail.com writes:
> From: Yurii Kolesnykov
>
> Signed-off-by: Yurii Kolesnykov
> ---
> cvs.html | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/cvs.html b/cvs.html
> index 589b2df..4873680 100644
> --- a/cvs.html
> +++ b/cvs.html
> @@ -54,11
Thanks, Olaf.
After this commit master is compiling without issues on OSX.
Any plans about next release? It will very good to get rid off my ugly
patches from brew formula. Here is my PR for bump to 1.0.25:
https://github.com/Homebrew/homebrew-core/pull/2377
Please send me email before release so
From: Yurii Kolesnykov
Signed-off-by: Yurii Kolesnykov
---
cvs.html | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/cvs.html b/cvs.html
index 589b2df..4873680 100644
--- a/cvs.html
+++ b/cvs.html
@@ -54,11 +54,11 @@
You can clone from the following URIs
To:sane-devel@lists.alioth.debian.org:
--
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
to sane-devel-requ...@lists.alioth.debian.org
Yurii Kolesnykov writes:
> ---
> frontend/saned.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/frontend/saned.c b/frontend/saned.c
> index 3506eb3..5b28be4 100644
> --- a/frontend/saned.c
> +++ b/frontend/saned.c
> @@ -792,7 +792,7 @@ check_host (int fd)
> #ifdef
---
frontend/saned.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/frontend/saned.c b/frontend/saned.c
index 3506eb3..5b28be4 100644
--- a/frontend/saned.c
+++ b/frontend/saned.c
@@ -792,7 +792,7 @@ check_host (int fd)
#ifdef ENABLE_IPV6
sin6 = &remote_address.sin6;
Hi all,
I have a patch I developed for use on OpenWrt with procd, but is
probably also useful with systemd that allows sane to run in non-debug
mode in the foreground, as a non-privileged user.
I'm not sure of you patch guidelines so I include it both inline and as
an attachment.
Index: sa
Hi Mike,
Mike Frysinger writes:
> On 04 Nov 2015 17:48, Olaf Meeuwissen wrote:
>> Thanks for the patch but what is this trying to fix?
>
> using the 1.0.25 release:
> $ make check
> ...
> Making check in tools
> make[2]: Entering directory
> '/usr/local/src/sane-backends/sane-backends-1.0.25/tes
On 04 Nov 2015 17:48, Olaf Meeuwissen wrote:
> Thanks for the patch but what is this trying to fix?
using the 1.0.25 release:
$ make check
...
Making check in tools
make[2]: Entering directory
'/usr/local/src/sane-backends/sane-backends-1.0.25/testsuite/tools'
Testing ../../tools/sane-desc w
Hi Mike,
Mike Frysinger writes:
> The old configure.in name has long been deprecated, and newer autotools
> will start throwing errors when encountered. Switch to configure.ac.
There's a "work-in-progress" that aims to update the autotool bits. You
can find it in the autotool-reform branch of
Hi Mike,
Mike Frysinger writes:
Thanks for the patch but what is this trying to fix?
When I run a make check on current head (33495ef) none of the tests in
testsuite/tools/ fails. Also, there is a commit (febae63a) that means
to handle version number changes.
$ make -C testsuite/tools check
---
testsuite/tools/data/html-backends-split.ref | 2 +-
testsuite/tools/data/html-mfgs.ref | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/testsuite/tools/data/html-backends-split.ref
b/testsuite/tools/data/html-backends-split.ref
index 72fd949..ff56220 100644
--
The old configure.in name has long been deprecated, and newer autotools
will start throwing errors when encountered. Switch to configure.ac.
---
configure.in => configure.ac | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename configure.in => configure.ac (100%)
diff --git a/configure.in
Hi Yurii,
Yurii Kolesnykov writes:
> Signed-off-by: Yurii Kolesnykov
> ---
> backend/epsonds-io.c | 4
> include/sane/sanei_backend.h | 10 +-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/backend/epsonds-io.c b/backend/epsonds-io.c
> index 28bacfc..c
Olaf and Yurii,
The sys/type.h problem is the same I face while compiling with musl instead
of glibc.
There are just some files that miss it. I have a patch for them but it
still misses the ifdef around it.
Check the other patches that might easy your port.
https://github.com/openwrt/packages/blo
Hi Yurii,
Sorry for the late follow-up.
Yurii Kolesnykov writes:
> Hi Olaf, thanks for your feedback.
> Sorry, I forgot to include this comment in previous email.
>
>> > /*
>> > * SANE types and defines
>> > */
>> > diff --git a/include/sane/sanei_backend.h b/include/sane/sanei_backend.h
>> > in
---
frontend/saned.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/frontend/saned.c b/frontend/saned.c
index f74b8fa..d33b031 100644
--- a/frontend/saned.c
+++ b/frontend/saned.c
@@ -249,6 +249,7 @@ static int num_handles;
static int debug;
static int run
add support for getopt_long, adjust help message
---
frontend/saned.c | 75 +---
1 file changed, 45 insertions(+), 30 deletions(-)
diff --git a/frontend/saned.c b/frontend/saned.c
index 8eff6c7..f74b8fa 100644
--- a/frontend/saned.c
+++ b/fronte
move help text in a separate function
---
frontend/saned.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/frontend/saned.c b/frontend/saned.c
index ab36397..8eff6c7 100644
--- a/frontend/saned.c
+++ b/frontend/saned.c
@@ -3253,6 +3253,11 @@ run_inetd (char *sock)
move argument parsing logic from run_inetd() to main()
---
frontend/saned.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/frontend/saned.c b/frontend/saned.c
index e717ed2..ab36397 100644
--- a/frontend/saned.c
+++ b/frontend/saned.c
@@ -3172,7 +3172,7
move argument parsing logic from run_standalone() to main()
---
frontend/saned.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/frontend/saned.c b/frontend/saned.c
index 108512d..e717ed2 100644
--- a/frontend/saned.c
+++ b/frontend/saned.c
@@ -2923,7 +2923
Hi Olaf, thanks for your feedback.
Sorry, I forgot to include this comment in previous email.
> > /*
> > * SANE types and defines
> > */
> > diff --git a/include/sane/sanei_backend.h b/include/sane/sanei_backend.h
> > index 1b5afe2..982dedc 100644
> > --- a/include/sane/sanei_backend.h
> > +++ b/i
Signed-off-by: Yurii Kolesnykov
---
backend/epsonds-io.c | 4
include/sane/sanei_backend.h | 10 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/backend/epsonds-io.c b/backend/epsonds-io.c
index 28bacfc..c0bdc28 100644
--- a/backend/epsonds-io.c
+++ b/backe
Hi Yurii,
Thanks for your feedback but there are a few checks done by the
configure script that can/should be used to address the fixes the
suggest.
Yurii Kolesnykov writes:
> 4 files changed, 19 insertions(+)
>
> diff --git a/backend/pieusb_buffer.c b/backend/pieusb_buffer.c
> index 53bd867..2
4 files changed, 19 insertions(+)
diff --git a/backend/pieusb_buffer.c b/backend/pieusb_buffer.c
index 53bd867..23fc645 100644
--- a/backend/pieusb_buffer.c
+++ b/backend/pieusb_buffer.c
@@ -100,7 +100,13 @@
#include
#include
#include
+
+#ifdef __APPLE__
+#include
+#elif
#include
+#endi
Quick fixes for error I have encountered during compilation.
make check reports problem:
> File generated for html-backends-split mode is different from reference
I have no clue wath this error is about. Is this the real error?
Yurii Kolesnykov (1):
Port to OS X
backend/pieusb_buffer.c
Matteo Croce writes:
> Hi,
Hi Matteo,
> sorry for the late reply, I'm a bit busy right now, I preferred to
> submit only the patches that makes the code prettier without changing
> the daemon behaviour, so they can be merged in the meantime.
No problem. As we're in "code freeze" (or was that "
Hi,
sorry for the late reply,
I'm a bit busy right now, I preferred to submit only the patches that
makes the code prettier
without changing the daemon behaviour, so they can be merged in the meantime.
I will make the others later on, getopt long support and bind address.
Cheers,
Matteo
2015-09
Hi Matteo,
Matteo Croce writes:
> move argument parsing logic from run_standalone() to main()
This patch and the other two in thise series look fine. I'll keep them
in the queue for the first release after 1.0.25.
I assume you are still working on the other changes.
Looking forward to your pa
move help text in a separate function
---
frontend/saned.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/frontend/saned.c b/frontend/saned.c
index ab36397..93da1ff 100644
--- a/frontend/saned.c
+++ b/frontend/saned.c
@@ -3253,6 +3253,11 @@ run_inetd (char *sock)
move argument parsing logic from run_inetd() to main()
---
frontend/saned.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/frontend/saned.c b/frontend/saned.c
index e717ed2..ab36397 100644
--- a/frontend/saned.c
+++ b/frontend/saned.c
@@ -3172,7 +3172,7
move argument parsing logic from run_standalone() to main()
---
frontend/saned.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/frontend/saned.c b/frontend/saned.c
index 108512d..e717ed2 100644
--- a/frontend/saned.c
+++ b/frontend/saned.c
@@ -2923,7 +2923
Hi Matteo,
The PNG/JPEG support for scanimage will be part of 1.0.25. The saned
changes will not. That doesn't they won't get into 1.0.26, of course.
I just thought that "shoving" that into 1.0.25 was a bit too risky at
this point.
Let's take a step back and split changes up in slightly smaller
---
fix 1 bit scans colors
doc/scanimage.man| 4 +-
frontend/Makefile.am | 2 +-
frontend/scanimage.c | 118 +--
3 files changed, 118 insertions(+), 6 deletions(-)
diff --git a/doc/scanimage.man b/doc/scanimage.man
index 387e962..480d51e 10
---
fix 1 bit scans colors
acinclude.m4 | 13 +
configure.in | 1 +
doc/scanimage.man| 4 +-
frontend/Makefile.am | 2 +-
frontend/scanimage.c | 149 +++
5 files changed, 155 insertions(+), 14 deletions(-)
diff --git
2015-09-17 15:08 GMT+02:00 Olaf Meeuwissen :
> Hi Matteo,
>
> I also reviewed and tested this in more detail. The PNG remarks hold
> here as well and the 1-bit output is inverted.
>
> In addition, during testing I used --format=jpg which a bit to my
> surprise led to a PNM image. I know that was
2015-09-17 15:02 GMT+02:00 Olaf Meeuwissen :
> Hi Matteo,
>
> Sorry for not replying earlier.
>
> I've reviewed your patch in more detail and things look okay. There do
> not seem to be any leaks (only scanned a single image) as the valgrind
> output is the same as for PNM output.
>
> There is one
Hi Matteo,
I also reviewed and tested this in more detail. The PNG remarks hold
here as well and the 1-bit output is inverted.
In addition, during testing I used --format=jpg which a bit to my
surprise led to a PNM image. I know that was my fault but I thought
that recognizing this common three
Hi Matteo,
Sorry for not replying earlier.
I've reviewed your patch in more detail and things look okay. There do
not seem to be any leaks (only scanned a single image) as the valgrind
output is the same as for PNM output.
There is one showstopper though. The 1-bit scans come out inverted.
I u
Matteo Croce writes:
> 2015-09-14 13:19 GMT+02:00 Olaf Meeuwissen :
>> Matteo Croce writes:
>>
>>> 2015-09-13 7:18 GMT+02:00 Olaf Meeuwissen :
Matteo Croce writes:
[snip]
Code's usage: [ -a [ username ] | -d [ n ] | -s [ n ] ] | -h
Manual page : [ -a [ username ] | -d
add optional argument '-b' to let saned bind a specific address
---
doc/saned.man| 13 ++---
frontend/saned.c | 17 -
2 files changed, 22 insertions(+), 8 deletions(-)
diff --git a/doc/saned.man b/doc/saned.man
index 0264c01..6a09d42 100644
--- a/doc/saned.man
+++ b/do
Implement command line parsing using getopt,
replace the help string with a nicer one.
---
NEWS | 7 +
doc/saned.man| 15 +
frontend/saned.c | 94 +++-
3 files changed, 66 insertions(+), 50 deletions(-)
diff --git a/
2015-09-14 13:19 GMT+02:00 Olaf Meeuwissen :
> Matteo Croce writes:
>
>> 2015-09-13 7:18 GMT+02:00 Olaf Meeuwissen :
>>> Matteo Croce writes:
>>>
>>> [snip]
>>> Code's usage: [ -a [ username ] | -d [ n ] | -s [ n ] ] | -h
>>> Manual page : [ -a [ username ] | -d [ n ] | -s [ n ] | -h ]
>>> ge
Matteo Croce writes:
> 2015-09-13 7:18 GMT+02:00 Olaf Meeuwissen :
>> Matteo Croce writes:
>>
>> [snip]
>> Code's usage: [ -a [ username ] | -d [ n ] | -s [ n ] ] | -h
>> Manual page : [ -a [ username ] | -d [ n ] | -s [ n ] | -h ]
>> getopt : [-a username] [-d n] [-s n] [-h]
>>
>> An i
---
exit with error immediately if JPEG support is not compiled in
upscale for 1 bit depth scans to 8 bit gray
doc/scanimage.man| 4 +-
frontend/Makefile.am | 2 +-
frontend/scanimage.c | 118 +--
3 files changed, 118 insertions(+), 6 deleti
---
exit with error immediately if PNG support is not compiled in
acinclude.m4 | 13 +
configure.in | 1 +
doc/scanimage.man| 4 +-
frontend/Makefile.am | 2 +-
frontend/scanimage.c | 143 +++
5 files changed, 149 inse
2015-09-13 7:18 GMT+02:00 Olaf Meeuwissen :
> Matteo Croce writes:
>
>> Sorry about that, I'll fix in a new version, also what do you think
>> about a nicer help string like:
>> "Usage: %s [-a username] [-d n] [-s n] [-h]\n"
>
> Your suggestion made me take a second look and I noticed that I totall
2015-09-13 11:15 GMT+02:00 Olaf Meeuwissen :
> Matteo Croce writes:
>
>> 2015-09-12 9:13 GMT+02:00 Olaf Meeuwissen :
>>> Hi Matteo,
>>>
>>> Thanks for taking the trouble to add optional PNG and JPEG output
>>> support!
>>>
>>> I've done a quick review of both patches and there are a few things that
Matteo Croce writes:
> 2015-09-12 9:13 GMT+02:00 Olaf Meeuwissen :
>> Hi Matteo,
>>
>> Thanks for taking the trouble to add optional PNG and JPEG output
>> support!
>>
>> I've done a quick review of both patches and there are a few things that
>> I'd like to point out:
>>
>> - Why do you let user
Matteo Croce writes:
> Sorry about that, I'll fix in a new version, also what do you think
> about a nicer help string like:
> "Usage: %s [-a username] [-d n] [-s n] [-h]\n"
Your suggestion made me take a second look and I noticed that I totally
missed the fact that the usage message treats the o
1 - 100 of 614 matches
Mail list logo
