Re: [sane-devel] [janitorial] leading whitespace: spaces XOR tabs

2017-08-11 Thread David Niklas
On Wed, 12 Jul 2017 15:35:36 +0200 Gerhard Jäger wrote: > > This whole exercise has made me look at the whole code base in a > > little more detail and, quite frankly, the use of leading whitespace > > is a total and utter mess. Some places are better of than others but > > on the whole it's pre

Re: [sane-devel] [janitorial] leading whitespace: spaces XOR tabs

2017-07-21 Thread Olaf Meeuwissen
Hi, Gerhard Jäger writes: > Well - Olaf, > > seems nothing can stop you from doin' that ;) Convincing counter-arguments can but I can be hard to convince ;-) > I second Allan, so go on. If I ever will apply my changes, I think I can > live with it. > > Cheers, > Gerhard > > On 20.07.2017 at 1

Re: [sane-devel] [janitorial] leading whitespace: spaces XOR tabs

2017-07-21 Thread Gerhard Jäger
Well - Olaf, seems nothing can stop you from doin' that ;) I second Allan, so go on. If I ever will apply my changes, I think I can live with it. Cheers, Gerhard On 20.07.2017 at 15:07 m. allan noah wrote: Olaf, you make a pretty convincing case, especially as regards to your wider than avera

Re: [sane-devel] [janitorial] leading whitespace: spaces XOR tabs

2017-07-20 Thread m. allan noah
Olaf, you make a pretty convincing case, especially as regards to your wider than average exposure to the codebase. If you feel strongly about this, and are willing to do the work (which I think will be harder than you expect), then I will remove my objections. allan -- sane-devel mailing list:

Re: [sane-devel] [janitorial] leading whitespace: spaces XOR tabs

2017-07-20 Thread Olaf Meeuwissen
Hi all, Apologies for replying to my own, original post but I want to reply to all initial follow-up in a single post. First off, Gerhard, Allan, Johannes, many thanks for the feedback. Your summarized comments with my replies first, followed by in-line comments on my initial post. 1. The whol

Re: [sane-devel] [janitorial] leading whitespace: spaces XOR tabs

2017-07-13 Thread Johannes Meixner
Hello, only side-notes FYI (and somewhat off-topic): On Jul 12 10:23 m. allan noah wrote (excerpt): 1. I routinely use git blame to find out when I changed some line of code. A massive whitespace commit would wreck that. Yes, there are other ways to get that info after such a cleanup, but I'

Re: [sane-devel] [janitorial] leading whitespace: spaces XOR tabs

2017-07-12 Thread m. allan noah
1. I routinely use git blame to find out when I changed some line of code. A massive whitespace commit would wreck that. Yes, there are other ways to get that info after such a cleanup, but I'm lazy :) 2. I've read a great deal of other people's code over the years, and I am generally stumped by t

Re: [sane-devel] [janitorial] leading whitespace: spaces XOR tabs

2017-07-12 Thread Gerhard Jäger
Hi Olaf, On 12.07.2017 at 14:33 Olaf Meeuwissen wrote: Hi all, I just committed the last compiler warning fixes and made the Debian 9 builds "AWARE". Now any compiler warnings on all 4 Debian builds will bomb the build in question and hence prevent the creation of a new snapshot tarball. I me

[sane-devel] [janitorial] leading whitespace: spaces XOR tabs

2017-07-12 Thread Olaf Meeuwissen
Hi all, I just committed the last compiler warning fixes and made the Debian 9 builds "AWARE". Now any compiler warnings on all 4 Debian builds will bomb the build in question and hence prevent the creation of a new snapshot tarball. I mentioned[1] that the plustek-pp backend's indenting defied