Re: [sage-support] How to make a proper Pull Request to add Planar Maps in Sage

2025-03-26 Thread Victor Lrc
Hello, It was in fact private... I juste made it public sorry https://github.com/vicllo/PlanarMaps Best, Victor Le mercredi 26 mars 2025 à 16:27:08 UTC+1, jackson...@gmail.com a écrit : > Is your repository PlanarMaps private? The link doesn't seem to be working. > > Best, > Jackson > > On W

[sage-support] How to make a proper Pull Request to add Planar Maps in Sage

2025-03-26 Thread Victor Lrc
Hello, We are a group of students, and as part of a project, we have written a library for SageMath that implements planar maps (see, for example, https://www.irif.fr/~chapuy/AEC/coursHagenberg.pdf). We have already implemented a number of classes, methods, and visualizations, and we hope to p

Re: [sage-support] How to make a proper Pull Request to add Planar Maps in Sage

2025-03-26 Thread Jackson Walters
Is your repository PlanarMaps private? The link doesn't seem to be working. Best, Jackson On Wed, Mar 26, 2025 at 11:12 AM Victor Lrc wrote: > Hello, > > We are a group of students, and as part of a project, we have written a > library for SageMath that implements planar maps (see, for example,

Re: [sage-support] How to make a proper Pull Request to add Planar Maps in Sage

2025-03-26 Thread Jackson Walters
Perfect, I am able to see it now. It looks like there are at least a few thousand lines of code. I'm not the best person to answer this, but I'm first wondering if you want to do this all in one PR, or would you be able to break this up into multiple PRs in a modular fashion? I can say that for (e