Re: [sage-devel] Re: Proposal: ci codecov/patch reports but not fail

2024-10-27 Thread 'Martin R' via sage-devel
I would like to report from a personal experiment. Nudged towards looking at the codecov warnings by tscrim, I learned that several of them actually uncovered truly (non-obviously) dead code in https://github.com/sagemath/sage/pull/38446. Making sure that the code code indeed not be reached b

Re: [sage-devel] Re: Proposal: ci codecov/patch reports but not fail

2024-10-16 Thread Dima Pasechnik
On Sat, Oct 5, 2024 at 6:06 PM John H Palmieri wrote: > > > > On Saturday, October 5, 2024 at 6:38:20 AM UTC-7 Kwankyu Lee wrote: > > But I don't know how big a problem the codecov issue is ... > > > We want to regard the check failure as there is a problem with the PR that > the author sho

Re: [sage-devel] Re: Proposal: ci codecov/patch reports but not fail

2024-10-05 Thread Dima Pasechnik
"normal" codepaths ought to be tested. Error processing with try/except blocks might be hard to test in the 1st place, and less crucial. On 5 October 2024 14:38:19 BST, Kwankyu Lee wrote: > > > But I don't know how big a problem the codecov issue is ... > > >We want to regard the check fai