Re: [sage-devel] Re: Minimum Python version to 3.8

2021-05-15 Thread Dima Pasechnik
On Sat, May 15, 2021 at 12:19 AM 'Travis Scrimshaw' via sage-devel wrote: > > Thank you for the pointer for how to add the optional marker. Adding a dummy > spkg for when the Python version is sufficiently large feels like a much more > invasive hack around by going into the build system. ;) no

Re: [sage-devel] Re: Minimum Python version to 3.8

2021-05-14 Thread 'Travis Scrimshaw' via sage-devel
Thank you for the pointer for how to add the optional marker. Adding a dummy spkg for when the Python version is sufficiently large feels like a much more invasive hack around by going into the build system. ;) Jonathan, yes, that is how we can fix the code. The problem as I recall is the docte

Re: [sage-devel] Re: Minimum Python version to 3.8

2021-05-13 Thread Dima Pasechnik
On Thu, May 13, 2021 at 4:52 PM David Roe wrote: > > > > On Thu, May 13, 2021 at 6:09 AM Dima Pasechnik wrote: >> >> On Thu, May 13, 2021 at 1:34 AM 'Travis Scrimshaw' via sage-devel >> wrote: >> > >> > Own tag might be a goood way forward as the code itself can run on Python >> > 3.7 by avoidi

Re: [sage-devel] Re: Minimum Python version to 3.8

2021-05-13 Thread David Roe
On Thu, May 13, 2021 at 6:09 AM Dima Pasechnik wrote: > On Thu, May 13, 2021 at 1:34 AM 'Travis Scrimshaw' via sage-devel > wrote: > > > > Own tag might be a goood way forward as the code itself can run on > Python 3.7 by avoiding the multiprocessing. It would be purely to state > that we don't

Re: [sage-devel] Re: Minimum Python version to 3.8

2021-05-13 Thread Dima Pasechnik
On Thu, May 13, 2021 at 1:34 AM 'Travis Scrimshaw' via sage-devel wrote: > > Own tag might be a goood way forward as the code itself can run on Python 3.7 > by avoiding the multiprocessing. It would be purely to state that we don't > want to test the mp parts of the code. How do I make an option

Re: [sage-devel] Re: Minimum Python version to 3.8

2021-05-13 Thread 'jonatha...@googlemail.com' via sage-devel
It looks to me as if all of this ticket can be "fixed" to work with python 3.7 by just trying to import shared_memory. `start_worker_pool` should probably raise a proper error message, if the import of shared_memory failed previosly. The few doctests that explicitly call `start_worker_pool` can

Re: [sage-devel] Re: Minimum Python version to 3.8

2021-05-12 Thread David Roe
One way to do it is to modify the auto_optional_tags variable in sage.doctest.control lines 47-54 to add a more specific python version tag. This doesn't get you inequalities in versions though. You could also just add an if statement around your test if there are few enough of them (e.g. int(sys