Re: [sage-devel] Re: Graphs: Hamiltonian path vs. cycle

2017-10-18 Thread Jori Mäntysalo
On Wed, 18 Oct 2017, David Coudert wrote: But anyways, I found more. is_eulerian(path=True) will return either False OR an Eulerian path. This seems to be clearly wrong. It is not a correct behavior. This method should have a parameter `certificate`, default to False. When certificate is True

Re: [sage-devel] Re: Graphs: Hamiltonian path vs. cycle

2017-10-18 Thread David Coudert
> But anyways, I found more. is_eulerian(path=True) will return either False OR > an Eulerian path. This seems to be clearly wrong. It is not a correct behavior. This method should have a parameter `certificate`, default to False. When certificate is True, it returns a pair boolean and certifi

Re: [sage-devel] Re: Graphs: Hamiltonian path vs. cycle

2017-10-18 Thread Jori Mäntysalo
On Sat, 14 Oct 2017, Jori Mantysalo wrote: Just read Wikipedia page and found the term "traversable". It seems to be less common than semi-eulerian... But a suggestion based on this: Let's make four functions - is_eulerian - is_traversable - is_hamiltonian - is_traceable Crosslink is_euleria

Re: [sage-devel] Re: Graphs: Hamiltonian path vs. cycle

2017-10-14 Thread Jori Mäntysalo
On Sat, 14 Oct 2017, david.coud...@inria.fr wrote: It seems that "traceable graph" is more common (by googling), but then it seems very natural to have is_eulerian/is_semi_eulerian and is_hamiltonian/is_semi_hamiltonian. Opinions? We can do that, but first we have to agree on the definitions f

Re: [sage-devel] Re: Graphs: Hamiltonian path vs. cycle

2017-10-14 Thread David . Coudert
> It seems that "traceable graph" is more common (by googling), but then it > seems very natural to have is_eulerian/is_semi_eulerian and > is_hamiltonian/is_semi_hamiltonian. Opinions? > We can do that, but first we have to agree on the definitions for both eulerian/hamiltonian path/cycle,

Re: [sage-devel] Re: Graphs: Hamiltonian path vs. cycle

2017-10-14 Thread Jori Mäntysalo
On Sat, 14 Oct 2017, david.coud...@inria.fr wrote: I took some more time to thought about the will of unifying these behaviors (which is a good idea) and I now believe  it is not a good idea to use the same method / term to check if the graph has a hamiltonian cycle or a hamiltonian path. Doin

Re: [sage-devel] Re: Graphs: Hamiltonian path vs. cycle

2017-10-10 Thread Jori Mäntysalo
On Tue, 10 Oct 2017, Dima Pasechnik wrote: I cannot think of a reason other than different authors/reviewers, different weather, different amount of coffee... :-) Haha. I opened #24003 for this, but will wait some days to see if there will be more comments. -- Jori Mäntysalo