Re: [sage-devel] Re: Conjugacy classes code

2011-12-08 Thread David Joyner
On Thu, Dec 8, 2011 at 6:26 AM, javier wrote: > They were listed on the comments. I have upgraded the ticket > description to make it clearer. Sorry, I missed that. I have tested it on a mac and have seen no problems. I'll test it out on a linux machine now. > > Cheers, > Javier > > -- > To

Re: [sage-devel] Re: Conjugacy classes code

2011-12-08 Thread David Joyner
On Thu, Dec 8, 2011 at 4:52 AM, javier wrote: > Hi David, > > On Dec 7, 10:39 pm, David Joyner wrote: >> The following tests fail with sage-4.8.a3 on a 10.6.8 mac: >> >> jeeves:sage-4.8.alpha3 wdj$ ./sage -t  -force_lib >> "devel/sage/sage/groups/group.pyx" >> sage -t -force_lib "devel/sage/sage/

Re: [sage-devel] Re: Conjugacy classes code

2011-12-07 Thread David Joyner
On Wed, Dec 7, 2011 at 11:57 AM, javier wrote: > Hi Florent and Simon, > > many thanks! That makes sense, I really hadn't considered comparing a > conjugacy class with an object of a different type. Testsuite and all > test pass on my machine now, so the ticket is ready for review! The following

Re: [sage-devel] Re: Conjugacy classes code

2011-12-07 Thread Florent Hivert
Hi Simon, > On 7 Dez., 10:16, Simon King wrote: > > But in both cases, it is also assumed that you are using coercion. > > Hence, when the test "self==None" raises an error or returns a wrong > > result then it could also be that there is a wrong coercion. > > Ouch, sorry, I thought that y

Re: [sage-devel] Re: Conjugacy classes code

2011-12-06 Thread David Joyner
On Tue, Dec 6, 2011 at 1:58 PM, javier wrote: > > > On Dec 6, 6:55 pm, David Joyner wrote: >> I guess I am going blind. I don't see a _cmp_ >> inhttp://trac.sagemath.org/sage_trac/attachment/ticket/7886/trac_7886_c... >> Which line is it? > > Oops! > My bad, forgot to add the new conjugacy_class

Re: [sage-devel] Re: Conjugacy classes code

2011-12-06 Thread David Joyner
On Tue, Dec 6, 2011 at 1:39 PM, javier wrote: > Hi David, > > On Dec 6, 6:29 pm, David Joyner wrote: >> >> Where is it? Is it in one of the patches posted to the trac ticket? > > Yes, it is in trac_7886_conjugacy_classes.patch I guess I am going blind. I don't see a _cmp_ in http://trac.sagemat