Re: [sage-devel] optional package doctests badly broken

2018-05-19 Thread David Loeffler
On 11 May 2018 at 17:17, John Cremona wrote: > > > The patchbot David Loeffler and I run in Warwick is on a machine which has > Magma on it. > > John > I'd be grateful if someone could explain how to configure the patchbot to run the Magma optional doctests -- I couldn't find this in the patchbot

Re: [sage-devel] optional package doctests badly broken

2018-05-14 Thread Erik Bray
On Fri, May 11, 2018 at 5:11 PM, William Stein wrote: > > On Fri, May 11, 2018 at 7:37 AM Erik Bray wrote: >> >> On Thu, May 10, 2018 at 7:37 PM, Jeroen Demeyer >> wrote: >> > On 2018-05-10 17:20, Thierry wrote: >> >> >> >> Run more patchbots, with various combinations of optional packages >> >>

Re: [sage-devel] optional package doctests badly broken

2018-05-11 Thread Thierry
On Fri, May 11, 2018 at 05:17:16PM +0100, John Cremona wrote: > On 11 May 2018 at 16:11, William Stein wrote: > > > > > On Fri, May 11, 2018 at 7:37 AM Erik Bray wrote: > > > >> On Thu, May 10, 2018 at 7:37 PM, Jeroen Demeyer > >> wrote: > >> > On 2018-05-10 17:20, Thierry wrote: > >> >> > >> >

Re: [sage-devel] optional package doctests badly broken

2018-05-11 Thread John Cremona
On 11 May 2018 at 16:11, William Stein wrote: > > On Fri, May 11, 2018 at 7:37 AM Erik Bray wrote: > >> On Thu, May 10, 2018 at 7:37 PM, Jeroen Demeyer >> wrote: >> > On 2018-05-10 17:20, Thierry wrote: >> >> >> >> Run more patchbots, with various combinations of optional packages >> >> include

Re: [sage-devel] optional package doctests badly broken

2018-05-11 Thread William Stein
On Fri, May 11, 2018 at 7:37 AM Erik Bray wrote: > On Thu, May 10, 2018 at 7:37 PM, Jeroen Demeyer > wrote: > > On 2018-05-10 17:20, Thierry wrote: > >> > >> Run more patchbots, with various combinations of optional packages > >> included. > > > > > > -1 > > > > That would more the problem more

Re: [sage-devel] optional package doctests badly broken

2018-05-11 Thread Erik Bray
On Thu, May 10, 2018 at 7:37 PM, Jeroen Demeyer wrote: > On 2018-05-10 17:20, Thierry wrote: >> >> Run more patchbots, with various combinations of optional packages >> included. > > > -1 > > That would more the problem more visible at best, but it wouldn't *solve* > anything. Considering that op

Re: [sage-devel] optional package doctests badly broken

2018-05-10 Thread 'Martin R' via sage-devel
As far as I remember, no. But I may be mistaken. Am Donnerstag, 10. Mai 2018 21:00:12 UTC+2 schrieb Jeroen Demeyer: > > On 2018-05-10 20:40, 'Martin R' via sage-devel wrote: > > If there would have been a patchbot running the FriCAS doctests back > then > > There most likely was such a patchbot

Re: [sage-devel] optional package doctests badly broken

2018-05-10 Thread Dima Pasechnik
On Thursday, May 10, 2018 at 7:58:54 PM UTC+1, Jeroen Demeyer wrote: > > On 2018-05-10 20:53, Dima Pasechnik wrote: > > this would at least prevent tickets like #20382 from getting positive > > reviews... > > Some of the test failures were actually reported by patchbots, see for > example: >

Re: [sage-devel] optional package doctests badly broken

2018-05-10 Thread Jeroen Demeyer
On 2018-05-10 20:40, 'Martin R' via sage-devel wrote: If there would have been a patchbot running the FriCAS doctests back then There most likely was such a patchbot and it didn't help. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubsc

Re: [sage-devel] optional package doctests badly broken

2018-05-10 Thread Jeroen Demeyer
On 2018-05-10 20:53, Dima Pasechnik wrote: this would at least prevent tickets like #20382 from getting positive reviews... Some of the test failures were actually reported by patchbots, see for example: https://patchbot.sagemath.org/log/20382/Ubuntu/16.04/x86_64/4.4.0-119-generic/quasar/201

Re: [sage-devel] optional package doctests badly broken

2018-05-10 Thread Dima Pasechnik
On Thursday, May 10, 2018 at 6:38:01 PM UTC+1, Jeroen Demeyer wrote: > > On 2018-05-10 17:20, Thierry wrote: > > Run more patchbots, with various combinations of optional packages > > included. > > -1 > > That would more the problem more visible at best, but it wouldn't > *solve* anything.

Re: [sage-devel] optional package doctests badly broken

2018-05-10 Thread 'Martin R' via sage-devel
Taken to the extreme, we should get rid of doctests altogether, since they don't solve anything :-) Seriously, at least the FriCAS interface was broken several times because of trivial modifications. If there would have been a patchbot running the FriCAS doctests back then, this would have bee

Re: [sage-devel] optional package doctests badly broken

2018-05-10 Thread Jeroen Demeyer
On 2018-05-10 17:20, Thierry wrote: Run more patchbots, with various combinations of optional packages included. -1 That would more the problem more visible at best, but it wouldn't *solve* anything. -- You received this message because you are subscribed to the Google Groups "sage-devel"

Re: [sage-devel] optional package doctests badly broken

2018-05-10 Thread Thierry
On Thu, May 10, 2018 at 04:35:36PM +0100, John Cremona wrote: > On 10 May 2018 at 16:20, Thierry wrote: > > > Hi, > > > > On Thu, May 10, 2018 at 04:41:39PM +0200, Vincent Delecroix wrote: > > > Dear all, > > > > > > Probably because of #20382 a lot of optional doctests now do not pass > > > anym

Re: [sage-devel] optional package doctests badly broken

2018-05-10 Thread John Cremona
On 10 May 2018 at 16:20, Thierry wrote: > Hi, > > On Thu, May 10, 2018 at 04:41:39PM +0200, Vincent Delecroix wrote: > > Dear all, > > > > Probably because of #20382 a lot of optional doctests now do not pass > > anymore... I found very annoying that very often tickets break > > optional packages

Re: [sage-devel] optional package doctests badly broken

2018-05-10 Thread Thierry
Hi, On Thu, May 10, 2018 at 04:41:39PM +0200, Vincent Delecroix wrote: > Dear all, > > Probably because of #20382 a lot of optional doctests now do not pass > anymore... I found very annoying that very often tickets break > optional packages. Does anybody has ideas to make that happen less often?

[sage-devel] optional package doctests badly broken

2018-05-10 Thread Vincent Delecroix
Dear all, Probably because of #20382 a lot of optional doctests now do not pass anymore... I found very annoying that very often tickets break optional packages. Does anybody has ideas to make that happen less often? Best Vincent -- You received this message because you are subscribed to the Go