Re: [sage-devel] is_constant in the SymbolicRing

2016-01-09 Thread Daniel Krenn
On 2016-01-09 06:23, William Stein wrote: > A confusing name not in the global namespace isn't much better. How > about a rename that is clearer? Ideas > >is_named_constant >is_famous_constant >is_special_constant _is_registered_constant_ -- You received this message because you

Re: [sage-devel] is_constant in the SymbolicRing

2016-01-09 Thread Daniel Krenn
On 2016-01-09 08:51, William Stein wrote: > Is the function used anywhere else in sage? Just once in interfaces/maxima_lib.py -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send

Re: [sage-devel] is_constant in the SymbolicRing

2016-01-09 Thread Daniel Krenn
On 2016-01-09 09:27, Daniel Krenn wrote: > This is now > http://trac.sagemath.org/ticket/19850 needs_review -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sag

Re: [sage-devel] is_constant in the SymbolicRing

2016-01-09 Thread Volker Braun
Another argument against a public method name is that e is implemented as exp(1) and not as a named constant under the hood: sage: e.is_constant() False sage: pi.is_constant() True On Saturday, January 9, 2016 at 10:03:04 AM UTC+1, Ralf Stephan wrote: > > It is not used by users and developers h

Re: [sage-devel] is_constant in the SymbolicRing

2016-01-09 Thread Ralf Stephan
I agree this should be removed. It is not used by users and developers have isinstance. Regards, -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubs

Re: [sage-devel] is_constant in the SymbolicRing

2016-01-09 Thread Daniel Krenn
This is now http://trac.sagemath.org/ticket/19850 On 2016-01-08 18:16, Daniel Krenn wrote: > Dear all, > > from the method-name and also from the one-line description > "Return True if this symbolic expression is a constant." > of Expression.is_constant, I expected that this gives more or

Re: [sage-devel] is_constant in the SymbolicRing

2016-01-08 Thread William Stein
Is the function used anywhere else in sage? On Friday, January 8, 2016, Nathann Cohen wrote: > > A confusing name not in the global namespace isn't much better. How > about a > > rename that is clearer? Ideas > > Unless you mean the function to be called by the users, in which case > the name

Re: [sage-devel] is_constant in the SymbolicRing

2016-01-08 Thread Nathann Cohen
> A confusing name not in the global namespace isn't much better. How about a > rename that is clearer? Ideas Unless you mean the function to be called by the users, in which case the name and behaviour must be pretty clear to anyone, it is probably better to make it private. >is_named_con

Re: [sage-devel] is_constant in the SymbolicRing

2016-01-08 Thread William Stein
On Friday, January 8, 2016, Vincent Delecroix <20100.delecr...@gmail.com> wrote: > That would still expose the method in the namespace. Having "2" or > "log(2)" not being symbolic constant is confusing! I would definitely > prefer an "_is_symbolic_constant". A confusing name not in the global na

Re: [sage-devel] is_constant in the SymbolicRing

2016-01-08 Thread Bill Page
On 8 January 2016 at 12:16, Daniel Krenn wrote: > PPS: At the moment (not having answers to this posting), my favourite > implementation would be something like >def is_constant(self): >return not self.variables() > To give an obvious counter-example: SR(random()).is_constant() b

[sage-devel] is_constant in the SymbolicRing

2016-01-08 Thread Daniel Krenn
Dear all, from the method-name and also from the one-line description "Return True if this symbolic expression is a constant." of Expression.is_constant, I expected that this gives more or less the same result as checking whether symbolic expression has an empty .variables(). However, we have