[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-21 Thread Alexander Dreyer
Hello, > Can you post a link to the spkg. I've installed Sun Studio 12 update 1 > on my machine at home, which installs the Sun compilers in a different > directory to on 't2'. For some reason Sun changed the default from > /opt/SWUNspro which they have used for years, to /opt/sunstudio12.1 her

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-21 Thread Dr. David Kirkby
Alexander Dreyer wrote: > Hello, >> In order to obey this, the following lines should be added to >> patch/custom.py: > ok, that seems to fix it indeed. I've attached to corresponding > custom.py to the trac ticket. > > Regards, > Alexander Can you post a link to the spkg. I've installed Sun S

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-21 Thread Alexander Dreyer
Hello, > In order to obey this, the following lines should be added to > patch/custom.py: ok, that seems to fix it indeed. I've attached to corresponding custom.py to the trac ticket. Regards, Alexander -- Dr. rer. nat. Dipl.-Math. Alexander Dreyer Abteilung "Systemanalyse, Prognose und Regel

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-19 Thread Alexander Dreyer
Hello Dave, hello Martin, unfortunately, I didn't find the time to have a look at that the issue, but > The Sage install makefile defines CXX to be g++ so no code should ignore that. In order to obey this, the following lines should be added to patch/custom.py: --- try: CC = os.environ['CC'

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-18 Thread David Kirkby
2009/8/18 Minh Nguyen : > > Hi Alexander, > > On Tue, Aug 18, 2009 at 10:42 PM, Alexander > Dreyer wrote: >> >> Hello Martin, hello Dave, >> >>> Alright, thanks for checking this. I've CCed Alexander so he can tell me >>> what >>> he did back then and I can do it too >> as far as I can see it fro

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-18 Thread Minh Nguyen
Hi Alexander, On Tue, Aug 18, 2009 at 10:42 PM, Alexander Dreyer wrote: > > Hello Martin, hello Dave, > >> Alright, thanks for checking this. I've CCed Alexander so he can tell me what >> he did back then and I can do it too > as far as I can see it from the package, the patch is included. So > m

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-18 Thread Alexander Dreyer
Hello Martin, hello Dave, > Alright, thanks for checking this. I've CCed Alexander so he can tell me what > he did back then and I can do it too as far as I can see it from the package, the patch is included. So maybe, my fix fails for some reason. Is there somewhere on t2 an experimental Solaris

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-16 Thread Martin Albrecht
> I've marked > > http://trac.sagemath.org/sage_trac/ticket/6177 > > that as '[with patch; needs work]' as it breaks on Solaris. There were > previous issues on Solaris with PolyBoRi which were resolved. With the > updated .spkg, those issues return. Basically if the Sun C++ compiler > (CC) can be

[sage-devel] Re: patch reviews

2009-08-16 Thread Martin Albrecht
> Are > polybori-0-6-3.4.patch > polybori-0-6-3.5.patch > > included in that spkg file? The patches were added after the link to the > .spkg file was posted. These are revisions of the same patch. These are patches against the main Sage tree and thus not included in the SPKG. Cheers, Martin --

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-15 Thread Dr. David Kirkby
Martin Albrecht wrote: > http://trac.sagemath.org/sage_trac/ticket/6177 > > but is there a .spkg file to test it with? The ticket says: "The SPKG is here: http://sage.math.washington.edu/home/malb/spkgs/polybori-0.6.spkg"; >>> Yes, but that link was posted 3 months a

[sage-devel] Re: patch reviews

2009-08-15 Thread Dr. David Kirkby
Martin Albrecht wrote: > On Saturday 15 August 2009, William Stein wrote: >> On Sat, Aug 15, 2009 at 3:15 PM, Dr. David >> >> Kirkby wrote: >>> William Stein wrote: On Sat, Aug 15, 2009 at 2:58 PM, Dr. David Kirkby wrote: > William Stein wrote: >> Hi Sage-devel, >> >

[sage-devel] Re: patch reviews

2009-08-15 Thread Martin Albrecht
On Saturday 15 August 2009, William Stein wrote: > On Sat, Aug 15, 2009 at 3:15 PM, Dr. David > > Kirkby wrote: > > William Stein wrote: > >> On Sat, Aug 15, 2009 at 2:58 PM, Dr. David > >> > >> Kirkby wrote: > >>> William Stein wrote: > Hi Sage-devel, > > Sage-4.1.1 was just releas

[sage-devel] Re: patch reviews

2009-08-15 Thread William Stein
On Sat, Aug 15, 2009 at 3:15 PM, Dr. David Kirkby wrote: > > William Stein wrote: >> On Sat, Aug 15, 2009 at 2:58 PM, Dr. David >> Kirkby wrote: >>> William Stein wrote: Hi Sage-devel, Sage-4.1.1 was just released, so now is a perfect time to review a few patches.  Spend a few

[sage-devel] Re: patch reviews

2009-08-15 Thread Dr. David Kirkby
William Stein wrote: > On Sat, Aug 15, 2009 at 2:58 PM, Dr. David > Kirkby wrote: >> William Stein wrote: >>> Hi Sage-devel, >>> >>> Sage-4.1.1 was just released, so now is a perfect time to review a few >>> patches. Spend a few minutes soon, skim through >>> >>> http://trac.sagemath.org/sage

[sage-devel] Re: patch reviews

2009-08-15 Thread William Stein
On Sat, Aug 15, 2009 at 2:58 PM, Dr. David Kirkby wrote: > > William Stein wrote: >> Hi Sage-devel, >> >> Sage-4.1.1 was just released, so now is a perfect time to review a few >> patches.  Spend a few minutes soon, skim through >> >>     http://trac.sagemath.org/sage_trac/report/14 >> >> and revi

[sage-devel] Re: patch reviews

2009-08-15 Thread Dr. David Kirkby
William Stein wrote: > Hi Sage-devel, > > Sage-4.1.1 was just released, so now is a perfect time to review a few > patches. Spend a few minutes soon, skim through > > http://trac.sagemath.org/sage_trac/report/14 > > and review 1 ticket. > > -- William > > > I'd take a look at http://

[sage-devel] Re: patch reviews

2009-08-15 Thread William Stein
On Sat, Aug 15, 2009 at 2:23 PM, David Joyner wrote: > > On Sat, Aug 15, 2009 at 4:58 PM, William Stein wrote: >> >> Hi Sage-devel, >> >> Sage-4.1.1 was just released, so now is a perfect time to review a few >> patches.  Spend a few minutes soon, skim through >> >>    http://trac.sagemath.org/sag

[sage-devel] Re: patch reviews

2009-08-15 Thread David Joyner
On Sat, Aug 15, 2009 at 4:58 PM, William Stein wrote: > > Hi Sage-devel, > > Sage-4.1.1 was just released, so now is a perfect time to review a few > patches.  Spend a few minutes soon, skim through > >    http://trac.sagemath.org/sage_trac/report/14 > > and review 1 ticket. I gave http://trac.s