[sage-devel] Re: is_singular method for matrices

2012-01-31 Thread javier
Hi all, this is now #12370, patch ready for review at [1]. When making the proposed change I spotted an inconsistency in the error messages when calling A.determinant() for A a non-square matrix. If A is defined over QQ the error message says ValueError: incompatible matrix dimensions whereas o

[sage-devel] Re: is_singular method for matrices

2012-01-25 Thread Simon King
Hi William, On 25 Jan., 19:30, William Stein wrote: > > Small improvement, but an improvement. Also, I observed that some > > matrix functions use hand-made caches. Should we change those to use > > @cahced_method instead, or is this done by some design reason? > > There was no cached_method when

Re: [sage-devel] Re: is_singular method for matrices

2012-01-25 Thread William Stein
On Wed, Jan 25, 2012 at 11:45 AM, javier wrote: > Hi William, > > On Jan 25, 6:30 pm, William Stein wrote: >> I think is_singular should raise a ValueError if the input matrix is >> not square. > > Sure, that makes sense. My main point was arguing for the convenience > of using rank rather than d

[sage-devel] Re: is_singular method for matrices

2012-01-25 Thread javier
Hi William, On Jan 25, 6:30 pm, William Stein wrote: > I think is_singular should raise a ValueError if the input matrix is > not square. Sure, that makes sense. My main point was arguing for the convenience of using rank rather than determinant. > That is probably a good idea over ZZ or QQ and