Re: [sage-devel] Re: doctest quality and patchbots

2018-12-13 Thread Dima Pasechnik
I have a concrete and reproducible example where doing more doctests in a file breaks other, unrelated, doctests, see https://trac.sagemath.org/ticket/26856#comment:8 I don't even know where to start debugging this... On Thursday, November 29, 2018 at 12:58:34 PM UTC, E. Madison Bray wrote: > >

Re: [sage-devel] Re: doctest quality and patchbots

2018-11-29 Thread E. Madison Bray
On Thu, Nov 29, 2018 at 12:19 PM Jeroen Demeyer wrote: > > On 2018-11-29 10:38, E. Madison Bray wrote: > > But I sometimes get failures in tests depending on which order the > > *files* were run in. That's what I'm talking about. > > But that's really unusual (and unrelated to --randorder). I gu

Re: [sage-devel] Re: doctest quality and patchbots

2018-11-29 Thread Jeroen Demeyer
On 2018-11-29 10:38, E. Madison Bray wrote: But I sometimes get failures in tests depending on which order the *files* were run in. That's what I'm talking about. But that's really unusual (and unrelated to --randorder). Do you have *any* concrete example of such a failure? -- You received

Re: [sage-devel] Re: doctest quality and patchbots

2018-11-29 Thread 'Martin R' via sage-devel
Actually, I find it more problematic that sage -t --long may pass (which is what the patchbots check), but sage -t fails (which is what most users running the tests probably see) Martin Am Donnerstag, 29. November 2018 10:38:54 UTC+1 schrieb E. Madison Bray: > > On Wed, Nov 28, 2018 at 12:25 PM

Re: [sage-devel] Re: doctest quality and patchbots

2018-11-29 Thread E. Madison Bray
On Wed, Nov 28, 2018 at 12:25 PM Jeroen Demeyer wrote: > > On 2018-11-28 09:17, E. Madison Bray wrote: > > +1 There are several tests which, when run in an unusual order, result > > in random failures. This is obviously a failure of test isolation if > > nothing else, and such cases *should* be r

Re: [sage-devel] Re: doctest quality and patchbots

2018-11-28 Thread Jeroen Demeyer
On 2018-11-28 09:17, E. Madison Bray wrote: +1 There are several tests which, when run in an unusual order, result in random failures. This is obviously a failure of test isolation if nothing else, and such cases *should* be rooted out and fixed. It's not a failure of "test isolation" if nobod

Re: [sage-devel] Re: doctest quality and patchbots

2018-11-28 Thread E. Madison Bray
On Fri, Nov 23, 2018 at 4:23 PM Simon King wrote: > > Hi Jeroen, > > On 2018-11-23, Jeroen Demeyer wrote: > > On 2018-11-22 18:45, 'Martin R' via sage-devel wrote: > >> 1) would it be easy and desirable to make the patchbots run tests in > >> random order? > > > > Easy: yes > > Desirable: no, it

Re: [sage-devel] Re: doctest quality and patchbots

2018-11-23 Thread 'Martin R' via sage-devel
> In such a setup, doctest framework will need to keep a record of the particular order, and output it for each failure. otherwise things are not reproducible... I think that this would be great, but at least in the cases I looked at, the reason is that the reason for failure is different order

Re: [sage-devel] Re: doctest quality and patchbots

2018-11-23 Thread Dima Pasechnik
In such a setup, doctest framework will need to keep a record of the particular order, and output it for each failure. otherwise things are not reproducible... On Fri, 23 Nov 2018 15:23 Simon King Hi Jeroen, > > On 2018-11-23, Jeroen Demeyer wrote: > > On 2018-11-22 18:45, 'Martin R' via sage-de

[sage-devel] Re: doctest quality and patchbots

2018-11-23 Thread Simon King
Hi Jeroen, On 2018-11-23, Jeroen Demeyer wrote: > On 2018-11-22 18:45, 'Martin R' via sage-devel wrote: >> 1) would it be easy and desirable to make the patchbots run tests in >> random order? > > Easy: yes > Desirable: no, it would create a lot of doctest failures ... whose fixing is likely to