Re: [sage-devel] Re: _cleanup method in DifferentialForms class

2013-07-04 Thread Burcin Erocal
On Thu, 4 Jul 2013 04:49:16 -0700 (PDT) vdelecroix <20100.delecr...@gmail.com> wrote: > If the differential forms are somewhat immutable we may also save the > result of is_zero once for all. Why do not make is_zero a > cached_method of symbolic expressions ? Do you mean wrapping sage.symbolic.e

Re: [sage-devel] Re: _cleanup method in DifferentialForms class

2013-07-04 Thread vdelecroix
If the differential forms are somewhat immutable we may also save the result of is_zero once for all. Why do not make is_zero a cached_method of symbolic expressions ? Best, Vincent -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe

Re: [sage-devel] Re: _cleanup method in DifferentialForms class

2013-07-01 Thread Joris Vankerschaver
Hi Dox, In addition to the link that Leif provided, it would be good to open a ticket on trac first with a description of the changes you propose to make. Let me know if you need any further help. I'd be happy to review your patch when you're done. All the best, Joris On Friday, June 28, 20

[sage-devel] Re: _cleanup method in DifferentialForms class

2013-06-29 Thread leif
Dox wrote: I could try to change something... However, What is the way to provide a patch? Is it through github? http://sagemath.org/doc/developer/walk_through.html#submitting-a-change -leif -- () The ASCII Ribbon Campaign /\ Help Cure HTML E-Mail -- You received this message because you

Re: [sage-devel] Re: _cleanup method in DifferentialForms class

2013-06-28 Thread Dox
I could try to change something... However, What is the way to provide a patch? Is it through github? On Friday, 28 June 2013 09:36:47 UTC-4, Joris Vankerschaver wrote: > > > Symbolic expressions have a .is_trivial_zero() method which is more >> suitable for use here. It doesn't try anything adv

Re: [sage-devel] Re: _cleanup method in DifferentialForms class

2013-06-28 Thread Joris Vankerschaver
> Symbolic expressions have a .is_trivial_zero() method which is more > suitable for use here. It doesn't try anything advanced so it has > predictable runtime. > I just wanted to say that I had no idea that this function existed when I wrote that code, and it seems like a good idea to use i

Re: [sage-devel] Re: _cleanup method in DifferentialForms class

2013-06-27 Thread Burcin Erocal
On Thu, 27 Jun 2013 07:42:14 -0700 (PDT) Timo Kluck wrote: > I think most time is spend in the is_zero() method for a symbolic > expression, and that the reassignments you refer to are largely > irrelevant. The thing is that it can cost a lot of time to decide > whether, for example > > sin(x)c

[sage-devel] Re: _cleanup method in DifferentialForms class

2013-06-27 Thread Timo Kluck
I think most time is spend in the is_zero() method for a symbolic expression, and that the reassignments you refer to are largely irrelevant. The thing is that it can cost a lot of time to decide whether, for example sin(x)cos(x) - sin(2x)/2 is equal to zero, because there is so many things to