[sage-devel] Re: Wrong answer in IntegerModRing.multiplicative_subgroups

2009-05-06 Thread davidloeffler
OK. In that case I'll upload a fix for #5250 without addressing this issue, and just fudge the multiplicative_subgroups method so it returns the same wrong output it did before, so the doctest in congroup_gamma0 passes. Once we have a new abelian groups framework based on #5882, someone can then g

[sage-devel] Re: Wrong answer in IntegerModRing.multiplicative_subgroups

2009-05-06 Thread William Stein
On Wed, May 6, 2009 at 12:13 PM, John Cremona wrote: > > 2009/5/6 William Stein : >> >> On Wed, May 6, 2009 at 11:33 AM, davidloeffler >> wrote: >>> >>> On May 6, 7.10pm, William Stein wrote: Crap.   Thanks for spotting this.  Fortunately this is used in only one place in Sage; this on

[sage-devel] Re: Wrong answer in IntegerModRing.multiplicative_subgroups

2009-05-06 Thread John Cremona
2009/5/6 William Stein : > > On Wed, May 6, 2009 at 11:33 AM, davidloeffler > wrote: >> >> On May 6, 7.10pm, William Stein wrote: >>>Crap.   Thanks for spotting this.  Fortunately this is used in only >>> one place in Sage; this one line in congroup_gamma0.py: >>> >>>       return [GammaH(N, H)

[sage-devel] Re: Wrong answer in IntegerModRing.multiplicative_subgroups

2009-05-06 Thread William Stein
On Wed, May 6, 2009 at 11:33 AM, davidloeffler wrote: > > On May 6, 7.10pm, William Stein wrote: >>Crap.   Thanks for spotting this.  Fortunately this is used in only >> one place in Sage; this one line in congroup_gamma0.py: >> >>       return [GammaH(N, H) for H in R.multiplicative_subgroups()]

[sage-devel] Re: Wrong answer in IntegerModRing.multiplicative_subgroups

2009-05-06 Thread davidloeffler
On May 6, 7.10pm, William Stein wrote: >Crap. Thanks for spotting this. Fortunately this is used in only > one place in Sage; this one line in congroup_gamma0.py: > > return [GammaH(N, H) for H in R.multiplicative_subgroups()] Yes, that was how I noticed this -- my fix for 5250 caused mu

[sage-devel] Re: Wrong answer in IntegerModRing.multiplicative_subgroups

2009-05-06 Thread John Cremona
Do we have a function which returns (Z/NZ)* as an abelian group? Should not be hard since you could use pari's znstar function. Then you'll just run into the less than perfect abelian group codewhich as far as I know does not have a function returning all subgroups of a group. John 2009/5/6

[sage-devel] Re: Wrong answer in IntegerModRing.multiplicative_subgroups

2009-05-06 Thread William Stein
On Wed, May 6, 2009 at 10:58 AM, daveloeffler wrote: > > Just now I was doing some tinkering in sage.rings.integer_mod_ring > with the aim of fixing ticket #5250, where Sage wrongly claims that > (Z / 162Z)^* is non-cyclic when it is. That turned out to be easy to > fix, but in the process I disc