[sage-devel] Re: Versions mishandled while installing packages

2015-09-14 Thread Andrey Novoseltsev
OK: http://trac.sagemath.org/ticket/19212 On Monday, 14 September 2015 14:17:40 UTC-6, Volker Braun wrote: > > On Monday, September 14, 2015 at 10:05:45 PM UTC+2, Andrey Novoseltsev > wrote: >> >> PKG_BASE=`echo "$PKG_NAME" | sed 's/-.*//'` >> Does this sound like a good idea? Should work as long

[sage-devel] Re: Versions mishandled while installing packages

2015-09-14 Thread Volker Braun
On Monday, September 14, 2015 at 10:05:45 PM UTC+2, Andrey Novoseltsev wrote: > > PKG_BASE=`echo "$PKG_NAME" | sed 's/-.*//'` > Does this sound like a good idea? Should work as long as we do not allow > dashes in package names... > Why not? Who is validating the naming convention? Also misshandl

[sage-devel] Re: Versions mishandled while installing packages

2015-09-14 Thread Andrey Novoseltsev
Well, the fix that works for threejs is to replace PKG_BASE=`echo "$PKG_NAME" | sed 's/-[0-9].*//'` at https://github.com/sagemath/sage/blob/6.9.beta6/build/bin/sage-spkg#L238 with PKG_BASE=`echo "$PKG_NAME" | sed 's/-.*//'` Does this sound like a good idea? Should work as long as we do not al

[sage-devel] Re: Versions mishandled while installing packages

2015-09-14 Thread Volker Braun
I'm guessing this is because the version starts with a letter, breaking some regex. The package name is threejs and not threejs-r70. As a note for script authors: The only way to translate between package and tarball name is $ sage --package tarball threejs threejs-r70.tar.gz $ sage --package