Re: [sage-devel] Re: VOTE: Revert merged PR with unreviewed dependencies

-1 to be in sync with my vote in #37796. On Friday, April 19, 2024 at 5:35:57 AM UTC+9 Marc Culler wrote: > > > On Thursday, April 18, 2024 at 12:47:36 PM UTC-5 David Roe wrote: > > On Thu, Apr 18, 2024 at 1:43 PM Matthias Koeppe wrote: > > I will first note that the title of this post is mislead

Re: [sage-devel] Re: VOTE: Revert merged PR with unreviewed dependencies

On Thursday, April 18, 2024 at 12:47:36 PM UTC-5 David Roe wrote: On Thu, Apr 18, 2024 at 1:43 PM Matthias Koeppe wrote: I will first note that the title of this post is misleading. Everything that was merged has been reviewed -- as noted, many months ago. I agree that everything was reviewed

[sage-devel] Re: VOTE: Revert merged PR with unreviewed dependencies

+1 to merge #37796. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://grou

Re: [sage-devel] Re: VOTE: Revert merged PR with unreviewed dependencies

On Thu, Apr 18, 2024 at 1:51 PM Matthias Koeppe wrote: > David, none of this explains the misleading use of the word "unreviewed". I believe that it does. If there was confusion, hopefully this exchange can help clarify it for others. David > On Thursday, April 18, 2024 at 10:47:36 AM UTC-7

Re: [sage-devel] Re: VOTE: Revert merged PR with unreviewed dependencies

David, none of this explains the misleading use of the word "unreviewed". On Thursday, April 18, 2024 at 10:47:36 AM UTC-7 David Roe wrote: > On Thu, Apr 18, 2024 at 1:43 PM Matthias Koeppe > wrote: > >> I will first note that the title of this post is misleading. >> Everything that was merged

Re: [sage-devel] Re: VOTE: Revert merged PR with unreviewed dependencies

On Thu, Apr 18, 2024 at 1:43 PM Matthias Koeppe wrote: > I will first note that the title of this post is misleading. > Everything that was merged has been reviewed -- as noted, many months ago. > I agree that everything was reviewed. However review refers not only to the action of giving appro

[sage-devel] Re: VOTE: Revert merged PR with unreviewed dependencies

I will first note that the title of this post is misleading. Everything that was merged has been reviewed -- as noted, many months ago. On Thursday, April 18, 2024 at 8:54:26 AM UTC-7 David Roe wrote: > Hi all, > Sage has had a review process for over 15 years, but a combination of > recent cha

[sage-devel] Re: VOTE: Revert merged PR with unreviewed dependencies

+1, yes, the unintended merge should be reverted. Martin On Thursday 18 April 2024 at 17:54:26 UTC+2 David Roe wrote: > Hi all, > Sage has had a review process for over 15 years, but a combination of > recent changes has led to the merging of a PR into sage-10.4.beta3 of a > change (#36964