Re: [sage-devel] Re: Unhandled case in EllipticCurve_from_cubic

2016-08-01 Thread Robin Houston
Okay, that’s reasonable. How about the attached, then? Robin On Sat, 30 Jul 2016 at 10:43 John Cremona wrote: > I think that an error should be raised if the projective point constructor > is called with (0,0,0). > On 29 Jul 2016 23:54, "Robin Houston" wrote: > > I think there’s another case t

Re: [sage-devel] Re: Unhandled case in EllipticCurve_from_cubic

2016-07-30 Thread John Cremona
I think that an error should be raised if the projective point constructor is called with (0,0,0). On 29 Jul 2016 23:54, "Robin Houston" wrote: I think there’s another case that isn’t handled correctly, exemplified by: R. = QQ[] T = EllipticCurve_from_cubic(y^2*z - x^3 - z^3, (0,1,0)) A simple

[sage-devel] Re: Unhandled case in EllipticCurve_from_cubic

2016-07-29 Thread Robin Houston
I think there’s another case that isn’t handled correctly, exemplified by: R. = QQ[] T = EllipticCurve_from_cubic(y^2*z - x^3 - z^3, (0,1,0)) A simple change that fixes this problem is to make the projective_point() method not blow up when given (0,0,0), e.g.: *--- a/src/sage/schemes/elliptic

Re: [sage-devel] Re: Unhandled case in EllipticCurve_from_cubic

2016-07-26 Thread John Cremona
On 25 Jul 2016 17:03, "leif" wrote: > > Jeroen Demeyer wrote: > > On 2016-07-25 13:07, John Cremona wrote: > >> Can someone make a trac ticket for this please? > > > > Done: https://trac.sagemath.org/ticket/21092 > > Ooops, race condition (I did look at the trac timeline!). > > On behalf of John (

[sage-devel] Re: Unhandled case in EllipticCurve_from_cubic

2016-07-25 Thread leif
Jeroen Demeyer wrote: > On 2016-07-25 13:07, John Cremona wrote: >> Can someone make a trac ticket for this please? > > Done: https://trac.sagemath.org/ticket/21092 Ooops, race condition (I did look at the trac timeline!). On behalf of John (Forgot your password?): https://trac.sagemath.org/tic