[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-18 Thread mhampton
As a first step I have made a new ticket for an improved spkg, which has "make check" test set in the makefile. If that looks OK I will try to get it merged upstream. So I would appreciate it if anyone can review #5018: http://trac.sagemath.org/sage_trac/ticket/5018. Marshall On Jan 18, 11:22

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-18 Thread John Cremona
2009/1/18 mabshoff : > > > > On Jan 18, 2:36 am, "John Cremona" wrote: > > Hi John, > >> > This obviously leads to the joke about the professor being asked what >> > his favorite programming language is and the answer being "PhD" :) >> >> I believe that is actually a *true* story, the prof in que

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-18 Thread mabshoff
On Jan 18, 8:43 am, mhampton wrote: > On Jan 17, 8:44 pm, mabshoff wrote: Hi Marshall, > > If you look at the Makefile of this code you should clearly see that > > it needs cleaning up and rewriting it from scratch in this case might > > be easier since only a couple files are involved. On p

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-18 Thread mabshoff
On Jan 18, 2:36 am, "John Cremona" wrote: Hi John, > > This obviously leads to the joke about the professor being asked what > > his favorite programming language is and the answer being "PhD" :) > > I believe that is actually a *true* story, the prof in question being > (Professor Sir Peter)

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-18 Thread mhampton
On Jan 17, 8:44 pm, mabshoff wrote: > If you look at the Makefile of this code you should clearly see that > it needs cleaning up and rewriting it from scratch in this case might > be easier since only a couple files are involved. On problem right off > the bat is that compiler as well as build

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-18 Thread mabshoff
On Jan 18, 6:34 am, mhampton wrote: > On Jan 17, 8:57 pm, William Stein wrote: Hi Marshall, > > I don't think there should even be a vote until you sign off on the > > platform support.   Getting new packages into sage involves two > > things:  (1) a list of minimum requirements about code q

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-18 Thread mhampton
On Jan 17, 8:57 pm, William Stein wrote: > I don't think there should even be a vote until you sign off on the > platform support. Getting new packages into sage involves two > things: (1) a list of minimum requirements about code quality and > portability, and (2) sufficient interest and s

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-18 Thread John Cremona
> This obviously leads to the joke about the professor being asked what > his favorite programming language is and the answer being "PhD" :) I believe that is actually a *true* story, the prof in question being (Professor Sir Peter) Swinnerton-Dyer. He was asked what programming language he used

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-17 Thread mabshoff
On Jan 17, 6:57 pm, William Stein wrote: > > And lrs can be build as a library and probably will so be integrated > > in Sage in the future. Since there are issues with LLP64 this is not a > > fun thing to debug, i.e. anything that can go wrong will lead to a > > segfault which isn't fun to

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-17 Thread William Stein
On Sat, Jan 17, 2009 at 6:44 PM, mabshoff wrote: > > > > On Jan 17, 12:56 pm, mhampton wrote: >> On Jan 17, 8:36 am, mabshoff wrote: > > Hi, > >> > But the code certainly needs prettying up, i.e. I couldn't find a test >> > suite, the files were all dumped in the same directory and on and on. >

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-17 Thread mabshoff
On Jan 17, 12:56 pm, mhampton wrote: > On Jan 17, 8:36 am, mabshoff wrote: Hi, > > But the code certainly needs prettying up, i.e. I couldn't find a test > > suite, the files were all dumped in the same directory and on and on. > > If upstream is interested I could certainly make some sugges

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-17 Thread Andrey Novoseltsev
I would be glad to have standard functions for triangulations! Andrey --~--~-~--~~~---~--~~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, vis

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-17 Thread mhampton
On Jan 17, 8:36 am, mabshoff wrote: > But the code certainly needs prettying up, i.e. I couldn't find a test > suite, the files were all dumped in the same directory and on and on. > If upstream is interested I could certainly make some suggestions. I don't think for such a small program that t

[sage-devel] Re: Proposal for inclusion of lrs as a standard package in Sage

2009-01-17 Thread mabshoff
On Jan 17, 6:17 am, mhampton wrote: Hi, > I would like a vote on including the lrs optional package as a > standard package in Sage. > > lrs stands for linear reverse search, an algorithm for computing > convex hulls which is quite different from that of cddlib (which is > already in Sage).