[sage-devel] Re: Kruskal's Algorithm using Priority Queues

2022-04-13 Thread davida...@gmail.com
Yes, you just need to change it back to "need review" so that it can be reviewed. Le mercredi 13 avril 2022 à 03:54:33 UTC-4, adarsh.k...@gmail.com a écrit : > Can I make these changes in https://trac.sagemath.org/ticket/33688 as > discussed? The ticket has not been closed yet > > On Wednesday,

[sage-devel] Re: Kruskal's Algorithm using Priority Queues

2022-04-13 Thread Adarsh Kishore
By the way, I opened https://trac.sagemath.org/ticket/33703 after a discussion on https://groups.google.com/g/sage-devel/c/R3r3G_Qrllo. If I am successful, we will test it to see if there are any performance improvements over the sequential version, else we can remove that line. Is that fine? On

[sage-devel] Re: Kruskal's Algorithm using Priority Queues

2022-04-13 Thread Adarsh Kishore
Can I make these changes in https://trac.sagemath.org/ticket/33688 as discussed? The ticket has not been closed yet On Wednesday, April 13, 2022 at 12:44:36 PM UTC+5:30 David Coudert wrote: > You are right, this can be removed too. > And I'm not sure a parallel version of Boruvka's algorithm is

[sage-devel] Re: Kruskal's Algorithm using Priority Queues

2022-04-13 Thread David Coudert
You are right, this can be removed too. And I'm not sure a parallel version of Boruvka's algorithm is needed. We already have a large number of spanning tree algorithms. On Tuesday, April 12, 2022 at 7:56:20 PM UTC+2 patrat...@gmail.com wrote: > Just wondering if the third TODO (Randomized span

[sage-devel] Re: Kruskal's Algorithm using Priority Queues

2022-04-12 Thread Enjeck Cleopatra
Just wondering if the third TODO (Randomized spanning tree construction) should be removed as well, since I see a function called "random_spanning_tree" exists already. On Monday, April 11, 2022 at 8:23:30 AM UTC+1 adarsh.k...@gmail.com wrote: > Okay, then I think that line should be removed rig

[sage-devel] Re: Kruskal's Algorithm using Priority Queues

2022-04-12 Thread Adarsh Kishore
https://trac.sagemath.org/ticket/33688 I have done the change On Tuesday, April 12, 2022 at 12:20:19 PM UTC+5:30 David Coudert wrote: > Sure, feel free to open a ticket to correct this. > > On Monday, April 11, 2022 at 4:18:38 PM UTC+2 adarsh.k...@gmail.com wrote: > >> I can open a ticket to corr

[sage-devel] Re: Kruskal's Algorithm using Priority Queues

2022-04-11 Thread David Coudert
Sure, feel free to open a ticket to correct this. On Monday, April 11, 2022 at 4:18:38 PM UTC+2 adarsh.k...@gmail.com wrote: > I can open a ticket to correct this if you want > > On Monday, April 11, 2022 at 12:53:30 PM UTC+5:30 Adarsh Kishore wrote: > >> Okay, then I think that line should be re

[sage-devel] Re: Kruskal's Algorithm using Priority Queues

2022-04-11 Thread Adarsh Kishore
I can open a ticket to correct this if you want On Monday, April 11, 2022 at 12:53:30 PM UTC+5:30 Adarsh Kishore wrote: > Okay, then I think that line should be removed right? It can be misleading > to potential contributors > > On Monday, April 11, 2022 at 12:31:02 PM UTC+5:30 David Coudert wro

[sage-devel] Re: Kruskal's Algorithm using Priority Queues

2022-04-11 Thread Adarsh Kishore
Okay, then I think that line should be removed right? It can be misleading to potential contributors On Monday, April 11, 2022 at 12:31:02 PM UTC+5:30 David Coudert wrote: > This query has been added in https://trac.sagemath.org/ticket/10433. > I don't think that priority queue can be of any hel

[sage-devel] Re: Kruskal's Algorithm using Priority Queues

2022-04-11 Thread David Coudert
This query has been added in https://trac.sagemath.org/ticket/10433. I don't think that priority queue can be of any help to speed up the current code. On Sunday, April 10, 2022 at 11:03:41 AM UTC+2 adarsh.k...@gmail.com wrote: > Hi everyone, > > I was going through Sage's codebase, and I came a