Re: [sage-devel] Re: Graph(....,format='elliptic_curve_congruence')

2015-10-09 Thread John Cremona
On 9 October 2015 at 10:00, John Cremona wrote: > On 9 October 2015 at 09:44, Nathann Cohen wrote: >>> Disclaimer -- I did not wrote that code and did not know it was there! >> >> Same here :-P >> >>> I agree that having this hidden away in graphs.py is not sensible, and >>> having it in src/sag

Re: [sage-devel] Re: Graph(....,format='elliptic_curve_congruence')

2015-10-09 Thread Nathann Cohen
> I can do that independently, if it will not cause conflicts with your > ongoing work. Works for me. You can base your branch on whatever you are using right now, and I will rebase it (if needed) atop of my refactoring. There will probably be a conflict, but very a probably one that is solved eas

Re: [sage-devel] Re: Graph(....,format='elliptic_curve_congruence')

2015-10-09 Thread John Cremona
On 9 October 2015 at 09:44, Nathann Cohen wrote: >> Disclaimer -- I did not wrote that code and did not know it was there! > > Same here :-P > >> I agree that having this hidden away in graphs.py is not sensible, and >> having it in src/sage/schemes/elliptic_curves/ is more sensible. >> >> How sh

Re: [sage-devel] Re: Graph(....,format='elliptic_curve_congruence')

2015-10-09 Thread Nathann Cohen
> Disclaimer -- I did not wrote that code and did not know it was there! Same here :-P > I agree that having this hidden away in graphs.py is not sensible, and > having it in src/sage/schemes/elliptic_curves/ is more sensible. > > How shall we do this? Would it work to make that a separate tick

Re: [sage-devel] Re: Graph(....,format='elliptic_curve_congruence')

2015-10-09 Thread John Cremona
Disclaimer -- I did not wrote that code and did not know it was there! I agree that having this hidden away in graphs.py is not sensible, and having it in src/sage/schemes/elliptic_curves/ is more sensible. How shall we do this? Would it work to make that a separate ticket from anything else yo

[sage-devel] Re: Graph(....,format='elliptic_curve_congruence')

2015-10-09 Thread Nathann Cohen
P.S.: It seems that this code is not called by *any* part of Sage: (read|…)~/sage$ grep "elliptic_curve_congruence" . -R ./graphs/graph.py: - ``'elliptic_curve_congruence'`` - data must be an ./graphs/graph.py:elif format == 'elliptic_curve_congruence': No doctest, no other functio