[sage-devel] Re: Doctest fails for Biopython-1.52.spkg

2009-10-11 Thread Marshall Hampton
I'd be happy to, although I will have a pro-positive review bias. -Marshall On Oct 11, 4:50 am, MaxTheMouse wrote: > I have put up a new package > athttp://sage.math.washington.edu/home/awebb/biopython-1.52.p0.spkg > if someone would like to review it. > > Adam --~--~-~--~~

[sage-devel] Re: Doctest fails for Biopython-1.52.spkg

2009-10-11 Thread MaxTheMouse
I have put up a new package at http://sage.math.washington.edu/home/awebb/biopython-1.52.p0.spkg if someone would like to review it. Adam --~--~-~--~~~---~--~~ To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send

[sage-devel] Re: Doctest fails for Biopython-1.52.spkg

2009-10-10 Thread William Stein
On Sat, Oct 10, 2009 at 11:09 AM, MaxTheMouse wrote: > > > > On Oct 10, 7:38 pm, Robert Bradshaw > wrote: >> There is an #optional directive one can pyt on doctests so they get >> run (and output tested) only if the user has installed the package. >> Sounds like that's what we should be using he

[sage-devel] Re: Doctest fails for Biopython-1.52.spkg

2009-10-10 Thread MaxTheMouse
On Oct 10, 7:38 pm, Robert Bradshaw wrote: > There is an #optional directive one can pyt on doctests so they get   > run (and output tested) only if the user has installed the package.   > Sounds like that's what we should be using here. > > - Robert > Unfortunately, these are not run by Sage

[sage-devel] Re: Doctest fails for Biopython-1.52.spkg

2009-10-10 Thread Robert Bradshaw
There is an #optional directive one can pyt on doctests so they get run (and output tested) only if the user has installed the package. Sounds like that's what we should be using here. - Robert On Oct 10, 2009, at 6:20 AM, MaxTheMouse wrote: > I decided to try patching the test but I now re

[sage-devel] Re: Doctest fails for Biopython-1.52.spkg

2009-10-10 Thread MaxTheMouse
I decided to try patching the test but I now realise that test_Wise.py is not actually the problem. In fact since I don't have the WISE2 software installed that test is skipped. The actual test is in the doc string of the module. """ >>> os.environ["WISE_KBYTE"]="30" >>> _build_align

[sage-devel] Re: Doctest fails for Biopython-1.52.spkg

2009-10-09 Thread MaxTheMouse
On Oct 9, 10:24 pm, Marshall Hampton wrote: > One alternative would be to patch the test_Wise.py file so that > instead of > > self.assert_(sys.stdout.getvalue().startswith("dnal -kbyte 10 > seq1.fna seq2.fna")) > > within test_dnal we'd have > > self.assert_(sys.stdout.getvalue().startswit

[sage-devel] Re: Doctest fails for Biopython-1.52.spkg

2009-10-09 Thread Marshall Hampton
One alternative would be to patch the test_Wise.py file so that instead of self.assert_(sys.stdout.getvalue().startswith("dnal -kbyte 10 seq1.fna seq2.fna")) within test_dnal we'd have self.assert_(sys.stdout.getvalue().startswith("dnal -kbyte 10") and similarly for test_psw. That wou