Re: [sage-devel] Re: Bug in category_singleton.__contains__ or in CombinatorialFreeModule

2020-06-21 Thread 'Travis Scrimshaw' via sage-devel
> > > $ git diff src/sage/sets/disjoint_union_enumerated_sets.py > diff --git a/src/sage/sets/disjoint_union_enumerated_sets.py > b/src/sage/sets/disjoint_union_enumerated_sets.py > index c6d35ea8bd..f5fdba7119 100644 > --- a/src/sage/sets/disjoint_union_enumerated_sets.py > +++ b/src/sage/se

Re: [sage-devel] Re: Bug in category_singleton.__contains__ or in CombinatorialFreeModule

2020-06-21 Thread 'Reimundo Heluani' via sage-devel
On Jun 20, 'Travis Scrimshaw' via sage-devel wrote: That definitely is not a bug in CombinatorialFreeModule, so there shouldn't be anything changed there. It is doing what it is told: that its indexing set is in finite sets. I would say the bug is purely in the DisjointUnionEnumeratedSets not doi

Re: [sage-devel] Re: Bug in category_singleton.__contains__ or in CombinatorialFreeModule

2020-06-20 Thread 'Travis Scrimshaw' via sage-devel
That definitely is not a bug in CombinatorialFreeModule, so there shouldn't be anything changed there. It is doing what it is told: that its indexing set is in finite sets. I would say the bug is purely in the DisjointUnionEnumeratedSets not doing a full check of its member sets. Best, Travis

Re: [sage-devel] Re: Bug in category_singleton.__contains__ or in CombinatorialFreeModule

2020-06-20 Thread 'Reimundo Heluani' via sage-devel
On Jun 20, Markus Wageringel wrote: I think the problem here is that enumerating over a disjoint union of an infinite set and a finite set will never reach the elements in the finite set. There is this comment in the documentation of DisjointUnionEnumeratedSets    Possible extensions: the cu

[sage-devel] Re: Bug in category_singleton.__contains__ or in CombinatorialFreeModule

2020-06-20 Thread Markus Wageringel
I think the problem here is that enumerating over a disjoint union of an infinite set and a finite set will never reach the elements in the finite set. There is this comment in the documentation of DisjointUnionEnumeratedSets Possible extensions: the current enumeration order is not suitable