Re: [sage-devel] Merging fix for github CI

On Wed, 8 Feb 2023 at 13:10, David Roe wrote: > > On Wed, Feb 8, 2023 at 12:23 PM 'Martin R' via sage-devel > wrote: >> >> Why would I need write access to the sagemath repo? >> >> I would have thought that I'd "somehow" (no idea how) take over the branch >> and modify it. Or are pull requests

Re: [sage-devel] Merging fix for github CI

cool, yes! Thank you for your patience! Martin On Wednesday, 8 February 2023 at 14:10:42 UTC+1 David Roe wrote: > On Wed, Feb 8, 2023 at 12:23 PM 'Martin R' via sage-devel < > sage-...@googlegroups.com> wrote: > >> Why would I need write access to the sagemath repo? >> >> I would have thought t

Re: [sage-devel] Merging fix for github CI

On Wed, Feb 8, 2023 at 12:23 PM 'Martin R' via sage-devel < sage-devel@googlegroups.com> wrote: > Why would I need write access to the sagemath repo? > > I would have thought that I'd "somehow" (no idea how) take over the branch > and modify it. Or are pull requests directly tied to a specific us

Re: [sage-devel] Merging fix for github CI

There must be some misunderstanding, I assume on my part. I *am* on the sagemath/triage team. But for trying and modifying a pull request, I certainly do not want write access to any of the "official" sage branches. I guess it will be best for me

Re: [sage-devel] Merging fix for github CI

On Wed, Feb 8, 2023 at 11:23 AM 'Martin R' via sage-devel wrote: > > Why would I need write access to the sagemath repo? you need to be on certain sagemath org team (in GitHub sense) called "triage" to be able to do meaningful things, such a reviewing/updating, with PRs. At the moment not all of

Re: [sage-devel] Merging fix for github CI

Why would I need write access to the sagemath repo? I would have thought that I'd "somehow" (no idea how) take over the branch and modify it. Or are pull requests directly tied to a specific user? In other words, what is the replacement for the following? Alice: git trac create "make sage eve

Re: [sage-devel] Merging fix for github CI

You need to use upstream (the official sage repo) instead of origin (your fork) to fetch the PR: git fetch upstream pull/PULL-REQUEST-ID/head:LOCAL-BRANCH-NAME see https://github.com/sagemath/trac-to-github/blob/master/docs/Migration-Trac-to-Github.md#for-reviewing-a-change If you don't have an

Re: [sage-devel] Merging fix for github CI

Interesting, because the PR page is still the same.for me. I feel so stupid, I'm sorry, I need more help. In particular, I get: martin@convex63:~/sage$ LANG=en git fetch origin pull/34974/head fatal: couldn't find remote ref pull/34974/head (Note that this is not *my* pull request, but somebo

Re: [sage-devel] Merging fix for github CI

On Wed, Feb 8, 2023 at 10:23 AM 'Martin R' via sage-devel wrote: > > Since the failures are > > sage -t --random-seed=130442615951932153031063473470828108756 > sage/schemes/elliptic_curves/ell_curve_isogeny.py # 1 doctest failed > sage -t --random-seed=130442615951932153031063473470828108756 > s

Re: [sage-devel] Merging fix for github CI

Since the failures are sage -t --random-seed=130442615951932153031063473470828108756 sage/schemes/elliptic_curves/ell_curve_isogeny.py # 1 doctest failed sage -t --random-seed=130442615951932153031063473470828108756 sage/schemes/elliptic_curves/ell_number_field.py # 2 doctests failed I assume

Re: [sage-devel] Merging fix for github CI

On Wed, 8 Feb 2023, 08:41 'Martin R' via sage-devel, < sage-devel@googlegroups.com> wrote: > I cannot see any "update branch" button on > https://github.com/sagemath/sage/pull/34974 > > Where should I look for it? > This button is somewhere near the ticket status at the bottom - if your base is i

Re: [sage-devel] Merging fix for github CI

I cannot see any "update branch" button on https://github.com/sagemath/sage/pull/34974 Where should I look for it? Martin On Wednesday, 8 February 2023 at 00:32:49 UTC+1 dim...@gmail.com wrote: > On Tue, Feb 7, 2023 at 10:42 PM David Roe wrote: > > > > Thanks Dima! > > > > There is now an "Up

Re: [sage-devel] Merging fix for github CI

On Tue, Feb 7, 2023 at 10:42 PM David Roe wrote: > > Thanks Dima! > > There is now an "Update branch" button at the bottom of each PR, which you > can press if you're the originator of the PR and it will merge in develop (there is an option to rebase rather than to merge on this button - althoug

Re: [sage-devel] Merging fix for github CI

Thanks Dima! There is now an "Update branch" button at the bottom of each PR, which you can press if you're the originator of the PR and it will merge in develop. David On Tue, Feb 7, 2023 at 8:18 PM Dima Pasechnik wrote: > done > > On Tue, Feb 7, 2023 at 6:54 PM John Cremona > wrote: > > > >

Re: [sage-devel] Merging fix for github CI

done On Tue, Feb 7, 2023 at 6:54 PM John Cremona wrote: > > Strong yes from me. > > #34987 concerns a 3-line doctest where only the first has a #long time tag > thought the other lines depend on the first having been run, so causes a > failure when tested without --long. The fix adds two # lon

Re: [sage-devel] Merging fix for github CI

Strong yes from me. #34987 concerns a 3-line doctest where only the first has a #long time tag thought the other lines depend on the first having been run, so causes a failure when tested without --long. The fix adds two # long time tags #34964 trims some whitespace and changes "" to r""" in a fe

[sage-devel] Merging fix for github CI

Hi all, Currently, almost all of the PRs on github aren't passing CI, and thus have red Xs. The problem can be resolved by merging #34964 and #34987 . Several of us