Re: [sage-devel] Meaning of --optional=sage in doctests

2018-08-30 Thread Timo Kaufmann
Also see the solutions I and jhpalmieri proposed in #26159[1]. I like those better because they still makes it possible to run optional doctests without running all of sages doctests. I think that is very valuable. The current example that started the discussion (very limited in scope) in #26110[2

Re: [sage-devel] Meaning of --optional=sage in doctests

2018-08-30 Thread Erik Bray
On Thu, Aug 30, 2018 at 11:04 AM Jeroen Demeyer wrote: > > At #26110 we noticed that the --optional option for doctests is really > strange when you don't specify "sage" as one of the optional packages. > > Here is how things currently work: any doctest line which doesn't > contain any other tag (

Re: [sage-devel] Meaning of --optional=sage in doctests

2018-08-30 Thread Michael Orlitzky
On 08/30/2018 05:04 AM, Jeroen Demeyer wrote: > > I can see two solutions: > > 1. Get rid of "--optional=sage" completely. An added bonus is that this > would slightly simplify the doctest framework. This is probably fine. Now that we have a grown-up build system, I see this as a consequence of

[sage-devel] Meaning of --optional=sage in doctests

2018-08-30 Thread Jeroen Demeyer
At #26110 we noticed that the --optional option for doctests is really strange when you don't specify "sage" as one of the optional packages. Here is how things currently work: any doctest line which doesn't contain any other tag (like "# optional - mypkg" or even "# long time") is treated as