On 2011-10-25 08:37, Jeroen Demeyer wrote:
> The following would be easy for me to do: remove all *newly added*
> trailing whitespace from patches (except on lines consisting only of
> spaces). Basically, s/^\(+.*[^ ]\) *$/\1/ in the patches.
I just tried to do this for sage-4.8.alpha1 and the pr
On 2011-10-25 09:51, Dan Drake wrote:
> I think that would be a good idea, although if you're just running that
> through sed, the exact patches applied would be different from the ones
> on the trac server, which would cause some confusion.
Very true, but I think that is only a minor annoyance.
On Tue, 25 Oct 2011 at 08:37AM +0200, Jeroen Demeyer wrote:
> The following would be easy for me to do: remove all *newly added*
> trailing whitespace from patches (except on lines consisting only of
> spaces). Basically, s/^\(+.*[^ ]\) *$/\1/ in the patches.
I think that would be a good idea, al
On 2011-10-25 02:33, Dan Drake wrote:
> It seems like no one wants to have an epic break-all-patches-in-trac
> patch that removes all the trailing whitespace in the Sage library --
> and, some people like some trailing whitespace, so perhaps we should
> also add just a warning to the sage-merge scr
On Mon, 24 Oct 2011 at 07:54AM -0700, Keshav Kini wrote:
> Shouldn't we have mention trailing whitespace somewhere in the developer's
> guide - namely telling people to omit it? Having such a policy makes for
> cleaner revision control, as most agree (for example, at some point git by
> default
On 2011-10-24 17:19, Keshav Kini wrote:
> By the way, I think trailing whitespace is often intentional. Some
> people consider this a good thing:
>
> Some text$
> $
> Some more text$
Personally, I do NOT consider this a problem. I would like to remove
whitespace after non-empty lines
By the way, I think trailing whitespace is often intentional. Some people
consider this a good thing:
Some text$
$
Some more text$
Some people also consider this a good thing:
-$
TITLE$
-$
Hell, I used to think these were good things until someone kn
The main point is that it would add legitimacy to people insisting that
patches not contain trailing whitespace before giving them positive review
on trac :)
-Keshav
Join us in #sagemath on irc.freenode.net !
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsub
On 2011-10-24 16:54, Keshav Kini wrote:
> If we take some stance on it, this will be reduced.
[citation needed]
It's obvious that it's better not to have trailing whitespace in files.
I'm not against adding a section in the developer's manual for this but
I doubt it will make any difference in pr
Hi all,
This is pretty trivial, but hey, sage-devel is a bit slow recently :)
Shouldn't we have mention trailing whitespace somewhere in the developer's
guide - namely telling people to omit it? Having such a policy makes for
cleaner revision control, as most agree (for example, at some point g
10 matches
Mail list logo
