Re: [sage-devel] Re: Governance proposal: Maintainer/code-owner model for .ci, .devcontainer, .github/workflows, tox.ini

2024-05-10 Thread Matthias Koeppe
On Friday, May 10, 2024 at 4:19:14 PM UTC-7 julian...@fsfe.org wrote: There are some means to reuse workflows in GitHub That's correct. They are called "reusable workflows", and I use them to provide portability testing to upstream projects of Sage. You can read about them in https://github.c

Re: [sage-devel] Re: Governance proposal: Maintainer/code-owner model for .ci, .devcontainer, .github/workflows, tox.ini

2024-05-10 Thread julian...@fsfe.org
Dear Matthias, If I read your proposal correctly, it is about removing review from changes made by "maintainers" and merging things directly into develop without waiting for the Release Manager. Mostly, I am opposed to this because changes to the files you list are not automatically uncontrove

[sage-devel] Re: scalar multiplication of module element fails

2024-05-10 Thread 'Martin R' via sage-devel
I think I've got it. In `free_module_element.pyx` the method `FreeModuleElement_generic_dense._lmul_` does the following: cpdef _lmul_(self, Element right): """ EXAMPLES:: sage: v = vector([-1,0,3,pi]) # needs sage.s

[sage-devel] Re: scalar multiplication of module element fails

2024-05-10 Thread 'Martin R' via sage-devel
Update: I'm afraid I misunderstood - this does call __mul__, right? On Friday 10 May 2024 at 15:20:07 UTC+2 Martin R wrote: > I am trying to fix > https://github.com/sagemath/sage/pull/37976#issuecomment-2104464722 > > Briefly: > > sage: h = SymmetricFunctions(QQ).h() > sage: v = vector([h[3]+

Re: [sage-devel] Re: Governance proposal: Maintainer/code-owner model for .ci, .devcontainer, .github/workflows, tox.ini

2024-05-10 Thread Matthias Koeppe
On Wednesday, May 8, 2024 at 12:18:51 PM UTC-7 Dima Pasechnik wrote: I've already said while the previous version of this was discussed, is that it's a huge mess to have different commit rights for different parts of the tree, I'm pretty sure that Volker and I can figure this out; there's no n

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-10 Thread Matthias Koeppe
FWIW, I suggested to implement this feature in https://github.com/sagemath/sage/issues/37254; I'm thankful to Aman Moon for implementing this feature and Sebastian Oehms for his help with it. Obviously a metric such as the number of lines of changes is only a one-dimensional way to express the

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-10 Thread Dima Pasechnik
On 9 May 2024 22:46:17 BST, Travis Scrimshaw wrote: >I am *very* strongly opposed to these tags. Their cutoffs are arbitrary nor >they serve no useful purpose as far as I can tell. To this point, they do >not reflect the difficulty of a review; in fact, they are at best >counterproductive to

[sage-devel] scalar multiplication of module element fails

2024-05-10 Thread 'Martin R' via sage-devel
I am trying to fix https://github.com/sagemath/sage/pull/37976#issuecomment-2104464722 Briefly: sage: h = SymmetricFunctions(QQ).h() sage: v = vector([h[3]+h[2,1]]) sage: v * (-111) ({[3]: 1, [2, 1]: 1}) One reason for this is possibly sage: a = coercion_model.get_action(v.parent(), ZZ, operat