Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-09 Thread seb....@gmail.com
I must confess that I have not thought about the aspects of these labels that Travis points out, but I fully understand these concerns. If they are annoying for many developers, the feature can be easily disabled by removing corresponding variables from the repository. Vincent Delecroix schrie

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-09 Thread Vincent Delecroix
I fully agree with Travis. I do not see the added value of these additional tags. On Thu, 9 May 2024 at 23:46, Travis Scrimshaw wrote: > > I am *very* strongly opposed to these tags. Their cutoffs are arbitrary nor > they serve no useful purpose as far as I can tell. To this point, they do not

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-09 Thread Travis Scrimshaw
I am *very* strongly opposed to these tags. Their cutoffs are arbitrary nor they serve no useful purpose as far as I can tell. To this point, they do not reflect the difficulty of a review; in fact, they are at best counterproductive to finding reviewers because it might deter people from revie

[sage-devel] Re: Governance proposal: Maintainer/code-owner model for .ci, .devcontainer, .github/workflows, tox.ini

2024-05-09 Thread Matthias Koeppe
On Wednesday, May 8, 2024 at 6:51:49 PM UTC-7 Kwankyu Lee wrote: The command "tox -e update_docker_platforms" involves a change of the list of tested platforms. The change become effective when a beta release is made by the release manager, since the docker image files are created only at the

[sage-devel] Re: Governance proposal: Maintainer/code-owner model for .ci, .devcontainer, .github/workflows, tox.ini

2024-05-09 Thread Volker Braun
+1 to the general idea of maintainers for distinct subtrees As far as the implementation, I'd rather follow a model where there is a single merge queue at the end (currently me, could be automated when the CI is stricter and developers do not / cannot ignore it any more). Otherwise we'll just