Re: [sage-devel] Re: should "foo?" print TESTS: blocks or omit them?

2015-11-06 Thread Jori Mäntysalo
On Fri, 6 Nov 2015, Tom Boothby wrote: A corollary to this is that relevant documentation should not exist in the TESTS block. True. And those edge cases should be documented. Maybe. But something like Graph().is_connected() is easy to check, if the user wants to know if empty graph is de

Re: [sage-devel] should "foo?" print TESTS: blocks or omit them?

2015-11-06 Thread Michael Orlitzky
On 11/06/2015 11:39 AM, John H Palmieri wrote: > > Please vote: > > [ ] 'foo?' should NOT display TESTS blocks. > > [ ] 'foo?' should display TESTS block. > Write-in candidate: make foo? show the source code at the end of the nicely-formatted docs, and then get rid of foo?? entirely. -- Y

Re: [sage-devel] Re: should "foo?" print TESTS: blocks or omit them?

2015-11-06 Thread Tom Boothby
A corollary to this is that relevant documentation should not exist in the TESTS block. And those edge cases should be documented. If the user wants to know more, foo?? will give them the Only True Documentation, which happens to include the TESTS block. [x] 'foo?' should NOT display TESTS bloc

[sage-devel] Re: should "foo?" print TESTS: blocks or omit them?

2015-11-06 Thread Travis Scrimshaw
> > [X] 'foo?' should display TESTS block. > > I think Thierry's argument about corner cases is a good one. Plus some docstrings have different input formats in the TESTS block or only have tests in the TESTS blocks (granted, this is only likely to occur in hidden functions, but I believe it i

Re: [sage-devel] bug in interreduced_basis

2015-11-06 Thread Eric Gourgoulhon
I confirm the crash on Ubuntu 14.04, 64-bits, with Sage 6.9, as well as with Sage 6.10.beta1, both compiled from source: Attaching gdb to process id 2853. Saved trace to /home/eric/.sage/crash_logs/sage_crash_iapJz_.log Unh

Re: [sage-devel] bug in interreduced_basis

2015-11-06 Thread Justin C. Walker
On Nov 6, 2015, at 08:40 , Diego Cifuentes wrote: > Sage 6.9 crashes while running the following code: > R. = PolynomialRing(QQ) > R.ideal(0).interreduced_basis() > The platform is Ubuntu 14.04, 64-bits. For the record, on OS X (both 10.6.8 and 10.10.5), this succeeds (with output [0]). Justin

Re: [sage-devel] should "foo?" print TESTS: blocks or omit them?

2015-11-06 Thread Justin C. Walker
On Nov 6, 2015, at 08:39 , John H Palmieri wrote: > At http://trac.sagemath.org/ticket/19503, we have a branch which implements > the omission of 'TESTS:' blocks in docstrings when you do 'foo?' (and > optionally, but this is not the default behavior, it can omit them in the > reference manual

[sage-devel] Re: Manifold equality and UniqueRepresentation

2015-11-06 Thread Eric Gourgoulhon
Le vendredi 6 novembre 2015 17:32:49 UTC+1, Nils Bruin a écrit : > > > Furthermore, if X and Y happen to be non-identical but "equal" charts, > would you want points._coordinates[X] be identical to points_coordinates[Y] > ? Would that ever be useful? > Not much: in the current setting, we shoul

Re: [sage-devel] Exceptions format; keyword 'implementation'

2015-11-06 Thread Volker Braun
On Friday, November 6, 2015 at 3:57:23 PM UTC+1, Daniel Krenn wrote: > > If it is a correct/full sentence, then it should start with a capital > letter and end with a full stop. > Which is another thing that Python never does; Its ZeroDivisionError: integer division or modulo by zero and

Re: [sage-devel] should "foo?" print TESTS: blocks or omit them?

2015-11-06 Thread David Roe
> > [ X] 'foo?' should NOT display TESTS blocks. > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group,

Re: [sage-devel] Re: sagemath 6.9 Ubuntu PPA: Error typesetting mathematics

2015-11-06 Thread Jan Groenewald
A new install from the PPA will work. It is unfortunately some upgrades since 6.6 that don't. Maybe we can add a sage-fix-mathjax.sh script. Or do it in postinst. I think we did for a while. Regards, Jan On 6 November 2015 at 19:32, Ding Pan wrote: > Thanks Jan! > Replacing mathjax fixed the pr

Re: [sage-devel] Exceptions format; keyword 'implementation'

2015-11-06 Thread Jori Mäntysalo
On Fri, 6 Nov 2015, Jeroen Demeyer wrote: 1) Should we raise ValueError("Bad things happened.") or ValueError("bad things happened")? There are 3559 error of the former form and 4150 of the latter. Python recommends the second style. OK. I guess it makes no harm to add a not of this to deve

Re: [sage-devel] should "foo?" print TESTS: blocks or omit them?

2015-11-06 Thread Jori Mäntysalo
On Fri, 6 Nov 2015, John H Palmieri wrote: As I said in the ticket: [X]  'foo?' should NOT display TESTS blocks. -- Jori Mäntysalo

[sage-devel] Re: sagemath 6.9 Ubuntu PPA: Error typesetting mathematics

2015-11-06 Thread Ding Pan
Thanks Jan! Replacing mathjax fixed the problem. Hope there will be a fix in PPA too. Ding On Monday, November 2, 2015 at 12:55:27 PM UTC-6, Jan Groenewald wrote: > > Hi > > This might be a leftover error from a previous versio nwhen mathjax moved. > Please try > > sudo -i > cd > /usr/lib/sage

Re: [sage-devel] should "foo?" print TESTS: blocks or omit them?

2015-11-06 Thread kcrisman
> > > > [ X ] 'foo?' should display TESTS block. > > Since they appear at the end of the doctest, there is no harm in > displaying > them, usually people stop reading when they find the information they were > looking for. > > Moreover, some tests deal about corner cases (empty sets, ...), he

Re: [sage-devel] should "foo?" print TESTS: blocks or omit them?

2015-11-06 Thread Thierry
Hi, On Fri, Nov 06, 2015 at 08:39:17AM -0800, John H Palmieri wrote: > At http://trac.sagemath.org/ticket/19503, we have a branch which implements > the omission of 'TESTS:' blocks in docstrings when you do 'foo?' (and > optionally, but this is not the default behavior, it can omit them in the

Re: [sage-devel] should "foo?" print TESTS: blocks or omit them?

2015-11-06 Thread William Stein
On Friday, November 6, 2015, John H Palmieri wrote: > At http://trac.sagemath.org/ticket/19503, we have a branch which > implements the omission of 'TESTS:' blocks in docstrings when you do 'foo?' > (and optionally, but this is not the default behavior, it can omit them in > the reference manual)

[sage-devel] bug in interreduced_basis

2015-11-06 Thread Diego Cifuentes
Sage 6.9 crashes while running the following code: R. = PolynomialRing(QQ) R.ideal(0).interreduced_basis() The platform is Ubuntu 14.04, 64-bits. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving ema

[sage-devel] should "foo?" print TESTS: blocks or omit them?

2015-11-06 Thread John H Palmieri
At http://trac.sagemath.org/ticket/19503, we have a branch which implements the omission of 'TESTS:' blocks in docstrings when you do 'foo?' (and optionally, but this is not the default behavior, it can omit them in the reference manual). There are pros and cons to this: for some time, our docu

[sage-devel] Re: Manifold equality and UniqueRepresentation

2015-11-06 Thread Nils Bruin
On Friday, November 6, 2015 at 2:58:24 AM UTC-8, Eric Gourgoulhon wrote: > > > However, your example with NAN in the reply to Simon shows that dictionary > lookup shortcuts equality testing on identical keys. If I understand > correctly, this means that even if we had a slow __eq__ for charts, a

[sage-devel] Re: Various issues with LaurentPolynomialRing

2015-11-06 Thread VulK
Here is a quick patch for one of the listed issues: http://trac.sagemath.org/ticket/19538 S. * Travis Scrimshaw [2015-11-04 16:37:17]: >Hey Salvatore, > > first of all thank you for your answer, it looks like you are one of > the > person I pester the most with these issues.

[sage-devel] Re: Manifold equality and UniqueRepresentation

2015-11-06 Thread Travis Scrimshaw
Hey Simon, > > On 2015-11-05, Travis Scrimshaw > wrote: > >I would then be advocating for using UniqueRepresentation if that was > > the only issue. > > It really depends whether in comparing manifolds you would prefer to do > *some* > heuristics to detect homeomorphic manifolds, or prefe

Re: [sage-devel] Exceptions format; keyword 'implementation'

2015-11-06 Thread Jeroen Demeyer
On 2015-11-06 15:57, Daniel Krenn wrote: Can you provide a reference for this? (I've tried to find, but didn't) Perhaps it's not written anywhere, but at least it's the style used by exceptions raised by Python itself: sage: int(1)/int(0) -

Re: [sage-devel] Exceptions format; keyword 'implementation'

2015-11-06 Thread Vincent Delecroix
On 06/11/15 11:57, Daniel Krenn wrote: On 2015-11-06 07:32, Jeroen Demeyer wrote: On 2015-11-06 12:27, Jori Mäntysalo wrote: 1) Should we raise ValueError("Bad things happened.") or ValueError("bad things happened")? There are 3559 error of the former form and 4150 of the latter. Python rec

Re: [sage-devel] Exceptions format; keyword 'implementation'

2015-11-06 Thread Daniel Krenn
On 2015-11-06 07:32, Jeroen Demeyer wrote: > On 2015-11-06 12:27, Jori Mäntysalo wrote: >> 1) Should we raise ValueError("Bad things happened.") or ValueError("bad >> things happened")? There are 3559 error of the former form and 4150 of >> the latter. > > Python recommends the second style. Can

Re: [sage-devel] Exceptions format; keyword 'implementation'

2015-11-06 Thread Daniel Krenn
On 2015-11-06 06:27, Jori Mäntysalo wrote: > 1) Should we raise ValueError("Bad things happened.") or ValueError("bad > things happened")? There are 3559 error of the former form and 4150 of > the latter. If it is a correct/full sentence, then it should start with a capital letter and end with a f

[sage-devel] Re: Manifold equality and UniqueRepresentation

2015-11-06 Thread Simon King
Hi Travis, On 2015-11-05, Travis Scrimshaw wrote: >I would then be advocating for using UniqueRepresentation if that was > the only issue. It really depends whether in comparing manifolds you would prefer to do *some* heuristics to detect homeomorphic manifolds, or prefer to consider manifo

Re: [sage-devel] Exceptions format; keyword 'implementation'

2015-11-06 Thread Jeroen Demeyer
On 2015-11-06 12:27, Jori Mäntysalo wrote: 1) Should we raise ValueError("Bad things happened.") or ValueError("bad things happened")? There are 3559 error of the former form and 4150 of the latter. Python recommends the second style. 3) Should we use keyword "algorithm" or "implementation"?

Re: [sage-devel] Re: Manifold equality and UniqueRepresentation

2015-11-06 Thread mmarco
But the random number generator suffers from the same issues: how random it really is deppends on the platform. I would suggest joining both ideas: random number plus time stamp. El jueves, 5 de noviembre de 2015, 17:08:11 (UTC+1), Jeroen Demeyer escribió: > > On 2015-11-05 16:27, Travis Scrims

[sage-devel] Exceptions format; keyword 'implementation'

2015-11-06 Thread Jori Mäntysalo
1) Should we raise ValueError("Bad things happened.") or ValueError("bad things happened")? There are 3559 error of the former form and 4150 of the latter. 2) raise("Must be over a Numberfield or a Numberfield Order") in src/sage/schemes/projective/projective_point.py should be corrected. 3) S

[sage-devel] Re: Manifold equality and UniqueRepresentation

2015-11-06 Thread Eric Gourgoulhon
Hi, Le vendredi 6 novembre 2015 00:16:26 UTC+1, Nils Bruin a écrit : > > On Thursday, November 5, 2015 at 2:35:57 PM UTC-8, Eric Gourgoulhon wrote: >> >> Yes charts are immutable: a chart is defined by two parameters, which are >> passed to the constructor: its domain (a manifold) and its coordi

[sage-devel] Re: Definition of multifactorial #5415

2015-11-06 Thread prateek sharma
Please review. On Wednesday, October 28, 2015 at 2:41:59 PM UTC+5:30, prateek sharma wrote: > > Hi, > I am looking for multifactorial function in the source code but unable > to.Help me out... > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To

[sage-devel] Re: Definition of multifactorial #5415

2015-11-06 Thread prateek sharma
https://github.com/prateekcs14/sage/commit/2cb944378c97bdad76a053e37d579d492f68d44c#commitcomment-14180664 On Wednesday, October 28, 2015 at 2:41:59 PM UTC+5:30, prateek sharma wrote: > > Hi, > I am looking for multifactorial function in the source code but unable > to.Help me out... > -- You r