[Rails-core] Re: Eager loading optimization patch

2007-10-28 Thread Frederick Cheung
On 29 Oct 2007, at 01:39, Mark Reginald James wrote: > > Pratik wrote: > >> I've uploaded a patch to optimize eager loading, which changes the >> code to spend less time in ruby - >> http://dev.rubyonrails.org/ticket/10011 >> >> The problem is because of following line in >> associations.rb:#con

[Rails-core] Re: Eager loading optimization patch

2007-10-28 Thread Mark Reginald James
Pratik wrote: > I've uploaded a patch to optimize eager loading, which changes the > code to spend less time in ruby - > http://dev.rubyonrails.org/ticket/10011 > > The problem is because of following line in > associations.rb:#construct_associations : > collection.target.push(association) unles

[Rails-core] Re: Eager loading optimization patch

2007-10-28 Thread Tarmo Tänav
Looks interesting. I don't have time to test this but have you tried to eager load several has_many associations at once (so there are M*N result rows) and compare the memory consumption of the new approach with the old one? On P, 2007-10-28 at 18:34 +, Pratik wrote: > Hi, > > I've uploaded