[Rails-core] ActionPack 2.3.9 form_helper_test fails when run "rake test"

2010-09-21 Thread nootch
I'm unable to get a successful run of the ActionPack 2.3.9 tests. I'm running REE 1.8.7. Here's a gist showing the failures: http://gist.github.com/590050 The failing test "form_helper_test" passes fine on its own, but fails when running "rake test". Digging into this a bit, it seems related to h

[Rails-core] Re: JSON - all keys should be quoted?

2009-01-13 Thread nootch
9:22 pm, nootch wrote: > Ok. Added a patch for this: > > http://github.com/weplay/rails/commit/b73fc178190a98a60d3e4e896e73c93... > > On Jan 12, 8:10 pm, "Mislav Marohnić" > wrote: > > > On Tue, Jan 13, 2009 at 01:20, nootch wrote: > > > > Is thi

[Rails-core] Re: JSON - all keys should be quoted?

2009-01-12 Thread nootch
Ok. Added a patch for this: http://github.com/weplay/rails/commit/b73fc178190a98a60d3e4e896e73c9380d7aeea1 On Jan 12, 8:10 pm, "Mislav Marohnić" wrote: > On Tue, Jan 13, 2009 at 01:20, nootch wrote: > > > Is this intentional or a bug? If all keys were double quoted

[Rails-core] JSON - all keys should be quoted?

2009-01-12 Thread nootch
I noticed that as of rails 2.x all hash keys were intended to be double quoted in JSON encodings. Indeed there's an ActiveSupport test method called "test_hash_key_identifiers_are_always_quoted". I noticed however that this isn't actually the case -- numeric keys are not double quoted: >> {1 => 2